Output warning when stack trace is undefined

facebook · Apr 18, 2017 · c01d9fe · c01d9fe
1 parent ab17832
commit c01d9fe
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/React/Base/RCTJSCErrorHandling.mm b/React/Base/RCTJSCErrorHandling.mm
@@ -13,6 +13,7 @@
 
 #import "RCTAssert.h"
 #import "RCTJSStackFrame.h"
+#import "RCTLog.h"
 
 NSString *const RCTJSExceptionUnsymbolicatedStackTraceKey = @"RCTJSExceptionUnsymbolicatedStackTraceKey";
 
@@ -25,7 +26,9 @@
     userInfo[NSLocalizedFailureReasonErrorKey] = exceptionMessage;
   }
   NSString *const stack = [exception[@"stack"] toString];
-  if ([stack length]) {
+  if ([@"undefined" isEqualToString:stack]) {
+    RCTLogWarn(@"Couldn't get stack trace for %@:%@", exception[@"sourceURL"], exception[@"line"]);
+  } else if ([stack length]) {
     NSArray<RCTJSStackFrame *> *const unsymbolicatedFrames = [RCTJSStackFrame stackFramesWithLines:stack];
     userInfo[RCTJSStackTraceKey] = unsymbolicatedFrames;
   }