Skip to content

Commit

Permalink
Fix codegen for CXX build
Browse files Browse the repository at this point in the history
Summary:
Fabric codegen is failing with running without specifying a specific platform. This diff fixes that.

Steps to reproduce:
```
buck build //xplat/js/react-native-github:generated_components-rncore --show-output
```

Error:
```
#include <react/renderer/imagemanager/primitives.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```

changelog: [internal] internal

Reviewed By: fkgozali

Differential Revision: D23114403

fbshipit-source-id: 50210e74f2a99ae5a77087988c3323bdacf04128
  • Loading branch information
mdvacca authored and facebook-github-bot committed Aug 14, 2020
1 parent 59a4d6f commit cc7dd18
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions ReactCommon/react/renderer/imagemanager/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ rn_xplat_cxx_library(
exclude = glob(["tests/**/*.cpp"]),
),
header_namespace = "",
exported_headers = subdir_glob(
[
("", "*.h"),
("platform/cxx", "**/*.h"),
],
prefix = "react/renderer/imagemanager",
),
compiler_flags = [
"-fexceptions",
"-frtti",
Expand Down

0 comments on commit cc7dd18

Please sign in to comment.