Print Hermes build script shell commands only in CI (#43767)

Summary: Pull Request resolved: #43767 Print Hermes build script shell commands only in CI. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55635527 fbshipit-source-id: f0a901e11c523987e97a28b5238dcc08586516dd
facebook · Apr 5, 2024 · d6c2149 · d6c2149
1 parent 627bff2
commit d6c2149
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh b/packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh
@@ -7,8 +7,6 @@
 # Defines functions for building various Hermes frameworks.
 # See build-ios-framework.sh and build-mac-framework.sh for usage examples.
 
-set -x -e
-
 CURR_SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 
 IMPORT_HERMESC_PATH=${HERMES_OVERRIDE_HERMESC_PATH:-$PWD/build_host_hermesc/ImportHermesc.cmake}

diff --git a/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh b/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh
@@ -4,7 +4,10 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-set -x -e
+if [ "$CI" ]; then
+  set -x
+fi
+set -e
 
 # Given a specific target, retrieve the right architecture for it
 # $1 the target you want to build. Allowed values: iphoneos, iphonesimulator, catalyst

diff --git a/packages/react-native/sdks/hermes-engine/utils/build-mac-framework.sh b/packages/react-native/sdks/hermes-engine/utils/build-mac-framework.sh
@@ -4,7 +4,10 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-set -x -e
+if [ "$CI" ]; then
+  set -x
+fi
+set -e
 
 # shellcheck source=xplat/js/react-native-github/sdks/hermes-engine/utils/build-apple-framework.sh
 CURR_SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"