Skip to content

Commit

Permalink
Remove default usages of enable_exceptions/rtti
Browse files Browse the repository at this point in the history
Summary: Changelog: [Internal]

Reviewed By: ShikaSD

Differential Revision: D34379947

fbshipit-source-id: abff08ec99cff60d16ff82b7c0422d72caffd59b
  • Loading branch information
javache authored and facebook-github-bot committed Feb 25, 2022
1 parent 13b0b06 commit dc50308
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/fabric/jni/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ rn_xplat_cxx_library(
],
prefix = "react/fabric",
),
compiler_flags_enable_exceptions = False,
compiler_flags_enable_rtti = False, # for YogaLayoutableShadowNode?
fbandroid_allow_jni_merging = True,
labels = ["supermodule:xplat/default/public.react_native.infra"],
platforms = ANDROID,
Expand Down
2 changes: 0 additions & 2 deletions ReactCommon/react/renderer/components/view/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ rn_xplat_cxx_library(
],
prefix = "react/renderer/components/view",
),
compiler_flags_enable_exceptions = False,
compiler_flags_enable_rtti = False, # YogaLayoutableShadowNode
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(),
force_static = True,
Expand Down
2 changes: 0 additions & 2 deletions ReactCommon/react/renderer/core/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ rn_xplat_cxx_library(
],
prefix = "react/renderer/core",
),
compiler_flags_enable_exceptions = False,
compiler_flags_enable_rtti = False, # Needed for DebugStringConvertible - need to find a non-RTTI way to do this / enable RTTI for debug builds only. Also EventBeat/AsyncEventBeat
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(),
force_static = True,
Expand Down

0 comments on commit dc50308

Please sign in to comment.