Skip to content

Commit

Permalink
Add BUCK targets for OSS hermes targets (#40933)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #40933

This enables us to have lint coverage (and others) for these files. Visibility is none, so it won't be pulled in to anything.

Also removed no-op JSITracing implementation.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D50262377

fbshipit-source-id: 6218c7a79b5c0328bed8472590cff9e92006b86e
  • Loading branch information
javache authored and facebook-github-bot committed Oct 13, 2023
1 parent 2d8797a commit edb7332
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
#include <hermes/inspector-modern/chrome/Registration.h>
#include <hermes/inspector/RuntimeAdapter.h>

#include "JSITracing.h"

using namespace facebook::hermes;
using namespace facebook::jsi;

Expand Down Expand Up @@ -243,8 +241,6 @@ HermesExecutor::HermesExecutor(
std::shared_ptr<MessageQueueThread> jsQueue,
const JSIScopedTimeoutInvoker& timeoutInvoker,
RuntimeInstaller runtimeInstaller)
: JSIExecutor(runtime, delegate, timeoutInvoker, runtimeInstaller) {
jsi::addNativeTracingHooks(*runtime);
}
: JSIExecutor(runtime, delegate, timeoutInvoker, runtimeInstaller) {}

} // namespace facebook::react
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include <hermes/hermes.h>
#include <jsireact/JSIExecutor.h>
#include <functional>
#include <utility>

namespace facebook::react {
Expand Down
16 changes: 0 additions & 16 deletions packages/react-native/ReactCommon/hermes/executor/JSITracing.cpp

This file was deleted.

16 changes: 0 additions & 16 deletions packages/react-native/ReactCommon/hermes/executor/JSITracing.h

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include "HermesInstance.h"

#include <JSITracing.h>
#include <jsi/jsilib.h>

#ifdef HERMES_ENABLE_DEBUGGER
Expand Down Expand Up @@ -129,8 +128,6 @@ std::unique_ptr<jsi::Runtime> HermesInstance::createJSRuntime(
std::unique_ptr<HermesRuntime> hermesRuntime =
hermes::makeHermesRuntime(runtimeConfigBuilder.build());

jsi::addNativeTracingHooks(*hermesRuntime);

#ifdef HERMES_ENABLE_DEBUGGER
std::unique_ptr<DecoratedRuntime> decoratedRuntime =
std::make_unique<DecoratedRuntime>(
Expand Down

0 comments on commit edb7332

Please sign in to comment.