Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix broken use_frameworks from React-bridging (#34011)
Summary: `use_frameworks!` is broken again in react-native 0.69 because React-bridging. in the `use_frameworks!` mode, header structures are flattened, so `#include <react/bridging/CallbackWrapper.h>` is not reachable to the header. to somehow workaround the issue without touch React-bridging imports, the pr do these things: - use `header_mappings_dir` to keep `react/bridging` header structure - because the header structure is not default framework header structure, explicitly `HEADER_SEARCH_PATHS` is necessary. - forward declare `CallbackWrapper` and use it internally in ReactCommon. so that we don't need to add `HEADER_SEARCH_PATHS` for React-bridging to every pods depending on `ReactCommon/turbomodule/core`, e.g. React-RCTSettings.podspec. ## Changelog [iOS] [Fixed] - Fix use_frameworks! for 0.69 Pull Request resolved: #34011 Test Plan: ```sh $ npx react-native init RN069 --version next # add `use_frameworks!` to ios/Podsfile # comment out use_flipper!() in ios/Podfile # patch node_modules/react-native with these changes $ yarn ios ``` Reviewed By: cortinico, cipolleschi Differential Revision: D37169699 Pulled By: dmitryrykun fbshipit-source-id: 309c55f1c611a2fc3902a83e8af814daaf2af6a0
- Loading branch information