[ios] Fix broken use_frameworks from React-bridging

[Kudo]

Summary

use_frameworks! is broken again in react-native 0.69 because React-bridging. in the use_frameworks! mode, header structures are flattened, so #include <react/bridging/CallbackWrapper.h> is not reachable to the header. to somehow workaround the issue without touch React-bridging imports, the pr do these things:

• use header_mappings_dir to keep react/bridging header structure
• because the header structure is not default framework header structure, explicitly HEADER_SEARCH_PATHS is necessary.
• forward declare CallbackWrapper and use it internally in ReactCommon. so that we don't need to add HEADER_SEARCH_PATHS for React-bridging to every pods depending on ReactCommon/turbomodule/core, e.g. React-RCTSettings.podspec.

Changelog

[iOS] [Fixed] - Fix use_frameworks! for 0.69

Test Plan

$ npx react-native init RN069 --version next
# add `use_frameworks!` to ios/Podsfile
# comment out use_flipper!() in ios/Podfile
# patch node_modules/react-native with these changes
$ yarn ios

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,787,847	+0
android	hermes	armeabi-v7a	7,176,742	+0
android	hermes	x86	8,097,679	+0
android	hermes	x86_64	8,075,549	+0
android	jsc	arm64-v8a	9,654,628	+0
android	jsc	armeabi-v7a	8,412,418	+0
android	jsc	x86	9,605,227	+0
android	jsc	x86_64	10,200,101	+0

Base commit: bcc69df
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: bcc69df
Branch: main

[cortinico]

cc @dmitryrykun

[Kudo]

thanks @cortinico @dmitryrykun. this is the minimum impact solution i can do so far. let me know whether it makes sense to you.
basically, the nested include or import like #include <react/bridging/CallbackWrapper.h> or #include <react/renderer/uimanager/primitives.h> will break use_frameworks. in framework header search, the formal way is #import <Framework/Header.h>. that's basically the main reason why use_frameworks is broken in new architecture mode. hopefully you can have some discussion for the nested import inside Meta.

[dmytrorykun]

Great work @Kudo, thanks!

[facebook-github-bot]

@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[Kudo]

cool. the internal CI failed from Meta looks success suddenly. that should be you folks from Meta helping. hopefully we can fix the use_frameworks problems soon.

[react-native-bot]

This pull request was successfully merged by @Kudo in f97c6a5.

^{When will my fix make it into a release? | Upcoming Releases}

[imWildCat]

Hello folks, I don't think this fix in in 0.69.0 as of now? Do we need a quick bump to include it?

➜  react-native git:(main) echo $(git tag --contains f97c6a5b498eec95e99a02c7842cb2ae160cd6cd)

➜  react-native git:(main)

[fortmarek]

Hey @imWildCat 👋

This is already in the list of commits for 0.69.1 release.

[imWildCat]

@fortmarek thanks for your prompt reply! I subscribed this discussion.

[mikehardy]

@imWildCat you might like https://github.com/mikehardy/rnfbdemo/blob/main/patches/react-native%2B0.69.0.patch