Add debug logs to track down T62192299 exception source

Summary: Add debug logs to track down T62192299 exception source Changelog: [Internal] Reviewed By: RSNara Differential Revision: D20878063 fbshipit-source-id: 94acd56c45d4b529a695d1b4d2bfd10d8f725e63
facebook · Apr 6, 2020 · ff38f47 · ff38f47
1 parent f21b4eb
commit ff38f47
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
@@ -1036,6 +1036,12 @@ public void run() {
  try {
  setupReactContext(reactApplicationContext);
  } catch (Exception e) {
+ // TODO T62192299: remove this after investigation
+ FLog.e(
+ ReactConstants.TAG,
+ "ReactInstanceManager caught exception in setupReactContext",
+ e);
+
  mDevSupportManager.handleException(e);
  }
  }

diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java
@@ -715,6 +715,9 @@ public void run() {
  }
 
  private void onNativeException(Exception e) {
+ // TODO T62192299: remove this after investigation
+ FLog.e(ReactConstants.TAG, "CatalystInstanceImpl caught native exception", e);
+
  mNativeModuleCallExceptionHandler.handleException(e);
  mReactQueueConfiguration
  .getUIQueueThread()

diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java
@@ -9,6 +9,7 @@
 
 import android.view.View;
 import androidx.annotation.Nullable;
+import com.facebook.common.logging.FLog;
 import com.facebook.react.bridge.DefaultNativeModuleCallExceptionHandler;
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.ReadableArray;
@@ -157,6 +158,9 @@ public void setPackagerLocationCustomizer(
 
  @Override
  public void handleException(Exception e) {
+ // TODO T62192299: remove this after investigation
+ FLog.e("DisabledDevSupportManager", "Caught exception", e);
+
  mDefaultNativeModuleCallExceptionHandler.handleException(e);
  }
 }