-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScrollView rendered incorrectly with RefreshControl if push back a bit before finish refreshing #10747
Comments
Having the same issue described by @nihgwu in my ListView. If I scroll down while the refresh is still processing, the space for the RefreshControl is still being rendered, which pushes down my stickyHeader and makes things look quite ugly. The Today sectionHeader should be directly underneath the StatusBar. |
My team has been encountering the same issue: Corresponding
With
When this #11700 makes it into a release, we are debating just disabling section sticky headers (or just rendering them as normal rows now to disable them). Finally, just to add some more context; it does appear there was an intentional commit a while back to resolve this issue: 34389c5. |
+1 |
2 similar comments
+1 |
+1 |
rename defualtHeight to _initialHeight, fix facebook#10747
set the y offset to 0, since 0 offset is where we want to be after we hide the refreshControl
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
Summary: set the y offset to 0, since 0 offset is where we want to be after we hide the refreshControl. Tested in emulator with ios 8, 9, 10 and also with section headers. Closes #15033 Differential Revision: D6265930 Pulled By: shergin fbshipit-source-id: b249c4713de68fc6b3a32cee7f995dc352315970
Summary: set the y offset to 0, since 0 offset is where we want to be after we hide the refreshControl. Tested in emulator with ios 8, 9, 10 and also with section headers. Closes facebook#15033 Differential Revision: D6265930 Pulled By: shergin fbshipit-source-id: b249c4713de68fc6b3a32cee7f995dc352315970
to reproduce:
Open the
RefreshControl
example inUIExplorer
for iOS, pull to refresh and then push back a bit(not hide the RefreshControl) before turning offrefreshing
, and you will see the issue every time with the latest code in master branch of React Native, the ScrollView bounces back with a space for RefreshControl witch is already disappeared instead of scroll to the topThe text was updated successfully, but these errors were encountered: