-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webview not showing loading indicator when calling reload() #11013
Labels
Help Wanted
Issues ideal for external contributors.
Resolution: Locked
This issue was locked by the bot.
Comments
Does the Android WebView ever show a loading indicator? It might not be implemented. Please send a PR to fix this. |
it showing for the first load but did not show when call with reload method
…On Nov 28, 2016 9:47 AM, "Martin Konicek" ***@***.***> wrote:
Does the Android WebView ever show a loading indicator? It might not be
implemented. Please send a PR to fix this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11013 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRr5wpcT35RbnRAxKk_cCO0YEJIx3yJks5rCjKjgaJpZM4K2MXt>
.
|
Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why. |
@hramos this is still an issue on android. We will try to fix this and send you a PR. |
Should be fixed with #15538 |
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 17, 2017
Summary: This commit enables state WebViewState before triggering reload on WebView. This will (if defined) trigger the loading screen again. On iOS the LoadingIndicator will be called whenever you reload the WebView. On Android this feature is missing (see #11013). This PR adds this behaviour. Important: One might think that "onLoadStart" is the right area to add this code, but on Android onLoadStart will also trigger for sub-resources -> the loading screen will also appear when loading iframes on the same page. I expect thats why this was not added in first place. (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) Closes #15538 Differential Revision: D5653257 Pulled By: hramos fbshipit-source-id: 908b82ddaf2c34048bcb833bc07e03ab68d09467
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Help Wanted
Issues ideal for external contributors.
Resolution: Locked
This issue was locked by the bot.
Description
Webview not showing loading indicator when calling reload() like below code, this only happen in android, IOS not problem.
this.refs[WEBVIEW_REF].reload();
Reproduction
`render() {
return (
};`
Solution
Please fix the so when we call reload, it show the loading indicator
Additional Information
The text was updated successfully, but these errors were encountered: