-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Illegal node ID set as an input for Animated.DiffClamp node #11317
Comments
0.42.0
|
@magicismight, @janicduplessis If you are using nativeDriver and Animated.diffClamp |
@arsenghazaryan I'm getting this error when the component is just mounted. |
Mounting works fine for me.
|
I'll have a look at this issue this week |
Hey @janicduplessis Thanks :) |
Just did :) #12910 |
Thanks a lot !!! |
Summary: There was some missing super.__detach calls in some Animated nodes, we rely on the base class being called to drop the node in the native implementation, not doing so will cause some nodes to leak. It also resulted in a crash when removing certain nodes because they would get updated after being detached. **Test plan** Reproduced the crash by unmounting a view that uses a DiffClamp node and made sure this fixes it. Also tested that other native animations still worked properly. Fixes facebook#11317 Closes facebook#12910 Differential Revision: D4718188 Pulled By: javache fbshipit-source-id: 179ec1334532152c124a9c0f447f488311925d0a
@janicduplessis Which version corrected this bug ? |
After I upgrade to RN0.40RC0( or perhaps it exists in RN0.39 as well, I will test it later) I get this error consistently, the only change is that I'm using native event(AnimatedScrollVIew) now, and it throw the error on both iOS and Android.
I try to comment this line
react-native/Libraries/NativeAnimation/Nodes/RCTDiffClampAnimatedNode.m
Line 56 in e1577df
There no other commits changed this DiffClamp implementation so I guess it's related to
AnimatedScrollVIew
, so any ideas? @janicduplessisThe text was updated successfully, but these errors were encountered: