Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.40] Commits to cherry-pick #11423

Closed
mkonicek opened this issue Dec 12, 2016 · 7 comments
Closed

[0.40] Commits to cherry-pick #11423

mkonicek opened this issue Dec 12, 2016 · 7 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@mkonicek
Copy link
Contributor

mkonicek commented Dec 12, 2016

Cherry-picking 11 days of commits because 0.40-stable had a huge breaking change for all iOS 3rd party libraries and this is the only way I know how to fix it:
https://github.com/facebook/react-native/commits/0.40-stable

Also cherry-picked:

  • Remove dependency on Yeoman (7ea40aa)
  • Fix a bug in determining if Yarn is available (9b53408)

Might also need:

@nihgwu
Copy link
Contributor

nihgwu commented Dec 12, 2016

@mkonicek I'm afraid that's not enough to resolve the <React/RTCXXX.h> migration issue, #11395 need to be cherry picked too or we can't submit the archived .ipa file

@sjmueller
Copy link
Contributor

Please read my comments regarding changes in 0.40: e1577df#commitcomment-20143360

tl;dr This still completely breaks anyone using Swift. I've tried many different configurations to unbreak our builds, but nothing helps. Please don't release a major version of RN and leave us Swift folks out in the cold!

@ncuillery
Copy link
Contributor

@mkonicek I computed the diff of the template from 0.39.2 to 0.40.0-rc.3:
ncuillery/rn-diff@rn-0.39.2...rn-0.40.0-rc.3
Maybe it could be useful for the team.

I didn't spot anything wrong in the template. But I guess some people would have a sharper eye.

@ide
Copy link
Contributor

ide commented Dec 29, 2016

Updated 0.40-stable with:

Sending to CI now.

@nihgwu
Copy link
Contributor

nihgwu commented Dec 29, 2016

So a new version would be cut tomorrow?

@ide
Copy link
Contributor

ide commented Dec 30, 2016

After some changes we'll also want to pull in #11667 (CocoaPods fix for tvOS by ptomasroos) and #11676 (Update React to ~15.4.1 instead of using RC by ide).

@ptomasroos
Copy link
Contributor

@ide I've changed my mind on the podspec, its not required to run RN 0.40 only to run master since this commit c92ad5f is not included in the release. We run master and thats why this occurred.

@grabbou grabbou closed this as completed Feb 2, 2017
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

8 participants