-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.40] Commits to cherry-pick #11423
Comments
Please read my comments regarding changes in 0.40: e1577df#commitcomment-20143360 tl;dr This still completely breaks anyone using Swift. I've tried many different configurations to unbreak our builds, but nothing helps. Please don't release a major version of RN and leave us Swift folks out in the cold! |
@mkonicek I computed the diff of the template from 0.39.2 to 0.40.0-rc.3: I didn't spot anything wrong in the template. But I guess some people would have a sharper eye. |
Updated 0.40-stable with:
Sending to CI now. |
So a new version would be cut tomorrow? |
Cherry-picking 11 days of commits because 0.40-stable had a huge breaking change for all iOS 3rd party libraries and this is the only way I know how to fix it:
https://github.com/facebook/react-native/commits/0.40-stable
Also cherry-picked:
Might also need:
The text was updated successfully, but these errors were encountered: