Move headers to project section to fix archive #11395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
referenced
this pull request
Dec 10, 2016
Summary: To make React Native play nicely with our internal build infrastructure we need to properly namespace all of our header includes. Where previously you could do `#import "RCTBridge.h"`, you must now write this as `#import <React/RCTBridge.h>`. If your xcode project still has a custom header include path, both variants will likely continue to work, but for new projects, we're defaulting the header include path to `$(BUILT_PRODUCTS_DIR)/usr/local/include`, where the React and CSSLayout targets will copy a subset of headers too. To make Xcode copy headers phase work properly, you may need to add React as an explicit dependency to your app's scheme and disable "parallelize build". Reviewed By: mmmulani Differential Revision: D4213120 fbshipit-source-id: 84a32a4b250c27699e6795f43584f13d594a9a82
facebook-github-bot
added
the
CLA Signed
|
successfully archived my app after merged this PR |
|
Hmm, with headers in project I saw issues when trying to build the tvOS and regular UIExplorer projects sequentially. What failures are you seeing? |
|
I'm trying this out on the v0.40 branch now, it looks like the Yoga headers are indeed incorrect, but they only need to be set to private. |
|
Ok, I've actually got the same set of changes locally, so I'll ship this. |
facebook-github-bot
added
the
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
ide
pushed a commit
that referenced
this pull request
Dec 29, 2016
Summary: Follow up to fix some issues with 59407f3. Headers needed to be in the `project` section instead of `private` in xcode so they don't get included in the archive. cc javache Closes #11395 Differential Revision: D4313048 Pulled By: javache fbshipit-source-id: 805dbbe9f149acfe780be76e99c949c450272358
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: Follow up to fix some issues with 59407f3. Headers needed to be in the `project` section instead of `private` in xcode so they don't get included in the archive. cc javache Closes facebook#11395 Differential Revision: D4313048 Pulled By: javache fbshipit-source-id: 805dbbe9f149acfe780be76e99c949c450272358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to fix some issues with 59407f3. Headers needed to be in the
projectsection instead ofprivatein xcode so they don't get included in the archive.cc @javache