-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Class prefixes: RCT, RK #119
Comments
We want to unify everything on RCT, but haven't done it yet. Where do you see an RC prefix without RCT? |
Apologies. I've been looking at things and it might be my dyslexia with the "RC" prefix. :-\ |
RK is short for "React Kit", which was the previous prefix we were using, but we've changed it to RCT (a contraction of "React", as you guessed) in accordance with Apple's guidelines on using three-letter prefixes, and to prevent clashing with RestKit. We just haven't cleaned up all the references in the JS code yet. |
Summary: This is annoying and confusing and is mostly fixable with a simple codemod. Let's try to make sure we don't introduce any new `RK` usage going forward (should use something like `FBRCT` instead). facebook#119 Test Plan: Run through all the OSS examples + holodeck Groups, MadMan, working on testing android.
@nicklockwood |
@hahaGitHub this doesn't seem related to the issue that you've commented on. It's better to create new issues rather than comment on an unrelated one. In any case, it sounds like there's either a problem with the packager on your system, or you've got the wrong sourceURL for your bundle. The packager runs in a window in the terminal, and creates a server running on localhost, normally on port 8081. It looks like you're trying to access it via 'http://localhost/index.ios.bundle', which would be port 8080 by default. In your browser, try accessing http://localhost/index.ios.bundle to see if it exists, and if not, try http://localhost:8081/index.ios.bundle instead. If the latter works, you need to change your sourceURL. If neither work, look in the packager window in the Terminal and see if there are any errors. If there is no packager window, it's not running, and that's the problem. |
@nickbalestra thank you your answer! |
@nickbalestra |
Are all of these contractions of "React"?
The text was updated successfully, but these errors were encountered: