-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCTWebSocketDebugger.xcodeproj #1290
Comments
I have related broken issues with 0.4.3
Opening it manually gives an alert informing us that:
And my own project fails to build due to linker errors related to RCTWebSocketExecutor which it is executing. I'm guessing that its been removed deliberately but our old projects still have them referenced. |
You probably did the same thing as me and updated your react-native for an existing project. We just need to remove it from our projects YourProject > Libraries > RCTWebSocketDebugger [should be a blue xcodeproj icon] Right click on it and delete it. Build succeeded ! |
You'll want to link the new RCTWebSocket library too so that you get back the Chrome debugger and the new WS polyfill. This probably should have been mentioned in the release notes. Someone else will have to confirm whether React is following semver, but if so, anything numbered 0.x.x is subject to API changes until it hits 1.0.0. That said I think the team generally has maintained backwards compatibility or added warnings during deprecation periods while keeping pace. |
How can I link the RCTWebSocket library? There's no xcodeproj under the WebSocket directory? |
The files might already be included then. If the Chrome debugger works for you everything is good. |
It doesn't work, there's no . xcodeproj under the WebSocket directory. but I managed to make one myself, and then linked it to the app project, so it works now. |
Hey guys, @vjeux mentioned that there is a fix in the works. The .xcodeproj got ignored by .hgignore. |
@dsibiski so adding that websocket folder wasn't long term solution? |
@myusuf3 AFAIK, they are working to get it back to an .xcodeproj library as it was before...that's based on a brief conversation I had with @vjeux earlier today. That could very well change. I believe @ide is working on a solution right now and there is an even better solution planned for the future in this Pull Request: #485 |
+1 Have the same problem |
@voronianski: if you upgrade to 0.4.4 it should work fine. Let me know if it doesn't |
@vjeux I still have such problem with |
@vjeux also I'm not sure regarding API changes with working on native modules. I saw somewhere on Twitter that |
@voronianski If you are still having the linker issue, it looks like it's because you need to remove the Also don't forget to add the 'libRCTWebSocket.a" file to the "Link Binary With Libraries" Build Phase. |
@dsibiski Thanks so much for this tip. |
@gaearon No problem! I'm glad it helped someone. :) |
Hi there! I am getting the following error while adding
Anyone knows why this might happen?, |
Never mind, I was including the library from the wrong place (ie. Outside of the default search path). |
This is broken in 0.4.3, it missed
*.h
,*.m
*.js
files that used to be there previously. Did you decide to go another way without any docs?I was that WebSockets in library worked when it was pulled into project, is this the new intended was to get web sockets for debugger working?
The text was updated successfully, but these errors were encountered: