Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTWebSocketDebugger.xcodeproj #1290

Closed
myusuf3 opened this issue May 15, 2015 · 18 comments
Closed

RCTWebSocketDebugger.xcodeproj #1290

myusuf3 opened this issue May 15, 2015 · 18 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@myusuf3
Copy link
Contributor

myusuf3 commented May 15, 2015

This is broken in 0.4.3, it missed *.h, *.m *.js files that used to be there previously. Did you decide to go another way without any docs?

I was that WebSockets in library worked when it was pulled into project, is this the new intended was to get web sockets for debugger working?

@myusuf3 myusuf3 closed this as completed May 15, 2015
@myusuf3 myusuf3 reopened this May 15, 2015
@crucialfelix
Copy link

I have related broken issues with 0.4.3

XCode is saying RCTWebSocketDebugger.xcodeproj has Workspace Integrity error, Couldn't load project

Opening it manually gives an alert informing us that:

Project /Users/crucial/code/bathyscaphe-react/node_modules/react-native/Libraries/RCTWebSocketDebugger/RCTWebSocketDebugger.xcodeproj cannot be opened because it is missing its project.pbxproj file.

And my own project fails to build due to linker errors related to RCTWebSocketExecutor which it is executing.

I'm guessing that its been removed deliberately but our old projects still have them referenced.

@crucialfelix
Copy link

You probably did the same thing as me and updated your react-native for an existing project.

We just need to remove it from our projects

YourProject > Libraries > RCTWebSocketDebugger [should be a blue xcodeproj icon]

Right click on it and delete it.

Build succeeded !

@ide
Copy link
Contributor

ide commented May 15, 2015

You'll want to link the new RCTWebSocket library too so that you get back the Chrome debugger and the new WS polyfill. This probably should have been mentioned in the release notes.

Someone else will have to confirm whether React is following semver, but if so, anything numbered 0.x.x is subject to API changes until it hits 1.0.0. That said I think the team generally has maintained backwards compatibility or added warnings during deprecation periods while keeping pace.

@xinthink
Copy link
Contributor

How can I link the RCTWebSocket library? There's no xcodeproj under the WebSocket directory?

@ide
Copy link
Contributor

ide commented May 15, 2015

The files might already be included then. If the Chrome debugger works for you everything is good.

@xinthink
Copy link
Contributor

It doesn't work, there's no . xcodeproj under the WebSocket directory.

but I managed to make one myself, and then linked it to the app project, so it works now.

@dsibiski
Copy link
Contributor

Hey guys, @vjeux mentioned that there is a fix in the works. The .xcodeproj got ignored by .hgignore.

@myusuf3
Copy link
Contributor Author

myusuf3 commented May 15, 2015

@dsibiski so adding that websocket folder wasn't long term solution?

@dsibiski
Copy link
Contributor

@myusuf3 AFAIK, they are working to get it back to an .xcodeproj library as it was before...that's based on a brief conversation I had with @vjeux earlier today. That could very well change. I believe @ide is working on a solution right now and there is an even better solution planned for the future in this Pull Request: #485

@voronianski
Copy link

+1 Have the same problem

@vjeux
Copy link
Contributor

vjeux commented May 16, 2015

@voronianski: if you upgrade to 0.4.4 it should work fine. Let me know if it doesn't

@vjeux vjeux closed this as completed May 16, 2015
@voronianski
Copy link

@voronianski
Copy link

@vjeux also I'm not sure regarding API changes with working on native modules.

I saw somewhere on Twitter that createReactIOSNativeComponentClass (https://github.com/voronianski/react-native-effects-view/blob/master/index.ios.js#L50) should be replaced with a new method.

@dsibiski
Copy link
Contributor

@voronianski If you are still having the linker issue, it looks like it's because you need to remove the RCTWebSocketDebugger.xcodeproj library from your app (that's the old one) and add the new RCTWebSocket.xcodeproj. See this page for help: http://facebook.github.io/react-native/docs/linking-libraries.html#content

Also don't forget to add the 'libRCTWebSocket.a" file to the "Link Binary With Libraries" Build Phase.

@gaearon
Copy link
Collaborator

gaearon commented May 28, 2015

@dsibiski Thanks so much for this tip.

@dsibiski
Copy link
Contributor

@gaearon No problem! I'm glad it helped someone. :)

@alfondotnet
Copy link

Hi there! I am getting the following error while adding RCTWebsocket.xcodeproj and linking to it:

Undefined symbols for architecture x86_64:
"_RCTGetExecutorID", referenced from:
 ___57-[RCTWebSocketExecutor sendMessage:context:waitForReply:]_block_invoke in         libRCTWebSocket.a(RCTWebSocketExecutor.o)
"_RCTNullIfNil", referenced from:
  -[RCTWebSocketManager webSocket:didCloseWithCode:reason:wasClean:] in libRCTWebSocket.a(RCTWebSocketManager.o)
"_RCTRegisterModule", referenced from:
  +[RCTWebSocketManager load] in libRCTWebSocket.a(RCTWebSocketManager.o)
  +[RCTWebSocketExecutor load] in libRCTWebSocket.a(RCTWebSocketExecutor.o)
"__RCTNotImplementedException", referenced from:
  -[RCTSRWebSocket init] in libRCTWebSocket.a(RCTSRWebSocket.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Anyone knows why this might happen?,
Thanks!

@alfondotnet
Copy link

Never mind, I was including the library from the wrong place (ie. Outside of the default search path).

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

10 participants