Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListView Paging header stays on "Section 0" #141

Closed
jaygarcia opened this issue Mar 11, 2015 · 5 comments
Closed

ListView Paging header stays on "Section 0" #141

jaygarcia opened this issue Mar 11, 2015 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jaygarcia
Copy link
Contributor

Just did a pull, See below.

list-view-paging
@sahrens
Copy link
Contributor

sahrens commented Mar 11, 2015

cc @nicklockwood - any ideas?

@nicklockwood
Copy link
Contributor

@sahrens, not yet, but I'm looking.

@nicklockwood
Copy link
Contributor

@sahrens I've figured it out. Fix incoming.

@nicklockwood
Copy link
Contributor

@jaygarcia we'll get a proper fix landed as soon as possible. In the meantime, if you change line number 328 in ScrollView.js to

stickyHeaderIndices: {diff: deepDiffer},

It should fix the problem for you locally.

@jaygarcia
Copy link
Contributor Author

@nicklockwood The latest updates have resolved the issue. Many thanks.

vjeux pushed a commit to vjeux/react-native that referenced this issue Apr 13, 2015
@nicklockwood
Fixed sticky section headers in ListView
ebc0a99 
Summary:
The sticky headers in ListView weren't working correctly, as reported here: facebook#141

It turns out that this was because the property was only ever being set to [1] (an array with a single index value of 1, reprenting the first header) so all the other headers were treated as regular rows and were scrolling under the first header.

It turns out that *that* was because the diffing function for stickyHeaders was wrong, or, more precisely, was a function when it should have been an object containing a function.

Test Plan: Run UIExplorer. Verify that paged scrolling example works.
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jaygarcia @nicklockwood @sahrens @react-native-bot