Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ListView] Touches callbacks do not work in ListView section headers [0.6.0v and higher] #2075

Closed
MattFoley opened this issue Jul 21, 2015 · 7 comments
Closed

[ListView] Touches callbacks do not work in ListView section headers [0.6.0v and higher] #2075

MattFoley opened this issue Jul 21, 2015 · 7 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@MattFoley
Copy link

I have a few native modules that were working in 0.5.0v. As of 0.6.0v, and in both v0.7.0, v0.7.1 they no longer receive touches.

I'm overriding touchesBegan/Moved/Cancelled/Ended, and these methods are never called on any item rendered in a sectionHeader.

If I comment out this method in RCTScrollView.h, everything works just peachy. This method was introduced in 0.6.0v, so my guess is that this is the culprit. I am not sure what it was introduced for, so I'm not sure how best to fix it.
@brentvatne brentvatne changed the title Touches callbacks do not work in ListView section headers [0.6.0v and higher] [ListView] Touches callbacks do not work in ListView section headers [0.6.0v and higher] Jul 21, 2015
@sahrens
Copy link
Contributor

sahrens commented Jul 21, 2015

@nicklockwood

On Jul 21, 2015, at 5:31 PM, Tj notifications@github.com wrote:

I have a few native modules that were working in 0.5.0v. As of 0.6.0v, and in both v0.7.0, v0.7.1 they no longer receive touches.

I'm overriding touchesBegan/Moved/Cancelled/Ended, and these methods are never called on any item rendered in a sectionHeader.

If I comment out this method in RCTScrollView.h, everything works just peachy. This method was introduced in 0.6.0v, so my guess is that this is the culprit. I am not sure what it was introduced for, so I'm not sure how best to fix it.

—
Reply to this email directly or view it on GitHub.

@MattFoley
Copy link
Author

I should add to this that once that method is removed, when a cell is scrolled behind a sticky header touches are then passed to the cell behind the section header, instead of the tappable item in the sticky header. This was the behavior in 0.5.0v as well.

@MattFoley
Copy link
Author

It's been a little over a week since I opened this issue, @nicklockwood @brentvatne do you have any advice? This will be a blocking issue for me before too long. Thanks!

@MattFoley MattFoley mentioned this issue Aug 4, 2015
Closed
vjeux pushed a commit to vjeux/react-native that referenced this issue Aug 10, 2015
[ListView] Fix RCTScrollView stickyHeader touch passing.
d8f4310 
Summary:
Point must be converted to the stickyHeader's coordinate space and then passed to the stickyHeaders hitTest:withEvent: method in order to be correctly routed to any subviews of the stickyHeader.

This resolves this [issue](facebook#2075).
Closes facebook#2224
Github Author: Tj <tfallon@Tjs-MBP.local>
@ide
Copy link
Contributor

ide commented Aug 15, 2015

Merged into 0.10.0-rc.

@ide ide closed this as completed Aug 15, 2015
@jaygarcia
Copy link
Contributor

@vjeux @ide @nicklockwood , seems like this issue still exists, per this recent post: #3577

@ide
Copy link
Contributor

ide commented Oct 21, 2015

@jaygarcia Looks a different issue, no? This issue was about the touch events not making their way to the event listeners.

@jaygarcia
Copy link
Contributor

Thanks @ide. My head is a bit fuzzy arm -- dealing with a cold.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jaygarcia @ide @MattFoley @sahrens @react-native-bot