Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test failure: D9614432 adds thecount dependency, but it's missing from open source #20994

Closed
hramos opened this issue Sep 6, 2018 · 8 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@hramos
Copy link
Contributor

hramos commented Sep 6, 2018

This can be observed in Circle CI with the following failure:

buck fetch ReactAndroid/src/test/java/com/facebook/react/modules
2018-09-06 00:08:43,732 [WARNING][buck_tool.py:450] Not using buckd because watchman isn't installed.
Picked up _JAVA_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap
PARSING BUCK FILES... 0.3s (100%)
No build file at ReactAndroid/src/main/java/com/facebook/thecount/BUCK when resolving target //ReactAndroid/src/main/java/com/facebook/thecount:thecount.
@hramos
Copy link
Contributor Author

hramos commented Sep 6, 2018

cc @gengjiawen who discovered this in b5d908b#diff-c348396d3d79622651a08ef206c42be5. I've pinged the author of that commit to see what can be done - it's unclear to me yet if thecount can be open sourced.

@hramos hramos changed the title [CI] Test failure: D9623235 adds thecount dependency, but it's missing from open source [CI] Test failure: D9614432 adds thecount dependency, but it's missing from open source Sep 6, 2018
@empyrical
Copy link
Contributor

Maybe the open source version could use a simple no-op shim?

@hramos
Copy link
Contributor Author

hramos commented Sep 10, 2018

@empyrical I think that's what we should go with. This thecount library is not meant to be open source.

@gengjiawen
Copy link
Contributor

Any response from the author ?

@hramos
Copy link
Contributor Author

hramos commented Sep 11, 2018

Yeah, I already chatted with the author. The code referenced here is not meant to be open sourced. We need to either roll back, or add a no-op shim as @empyrical suggested.

We also need to toughen up our internal land blocking tests to ensure they can catch issues like these in the future.

@gengjiawen
Copy link
Contributor

If the author can't fix it in short time, I am inclined to revert the commit, blocking master ci for a long time is not a good idea.

Also, for internal test, is it possible fb use something like docker to avoid some private code ?

@hramos
Copy link
Contributor Author

hramos commented Sep 11, 2018

No, we cannot use Docker.

@hramos
Copy link
Contributor Author

hramos commented Sep 11, 2018

We're reverting the change.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 22, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants