Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metro preset version #21034

Closed
wants to merge 1 commit into from
Closed

Fix Metro preset version #21034

wants to merge 1 commit into from

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Sep 10, 2018

This pull request removes the hard-coded version of the metro-react-native-babel-preset as defined in the init command. That way, the version always matches React Native version specified in its package.json, making it match Metro version.

CC: @kelset

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2018
@grabbou
Copy link
Contributor Author

grabbou commented Sep 10, 2018

This PR has been already merged to 0.57-stable branch and confirmed to work as a part of upcoming 0.57 release.

@react-native-bot react-native-bot added Core Team Missing Test Plan This PR appears to be missing a test plan. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Sep 10, 2018
kelset
kelset approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@grabbou
Copy link
Contributor Author

grabbou commented Sep 10, 2018

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

I will not rubber stamp and land your change for you @grabbou! I can import it for you and you can get your change reviewed by someone though :)

@grabbou
Copy link
Contributor Author

grabbou commented Sep 10, 2018

Unrelated: not sure why tests are breaking, but... this change is not covered on the CI anyway.

@Salakar
Copy link
Contributor

Salakar commented Sep 10, 2018

@grabbou the failure, for Android at least is being tracked here: #20994 - unrelated as you say :)

buck fetch ReactAndroid/src/test/java/com/facebook/react/modules
2018-09-06 00:08:43,732 [WARNING][buck_tool.py:450] Not using buckd because watchman isn't installed.
Picked up _JAVA_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap
PARSING BUCK FILES... 0.3s (100%)
No build file at ReactAndroid/src/main/java/com/facebook/thecount/BUCK when resolving target //ReactAndroid/src/main/java/com/facebook/thecount:thecount.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 10, 2018
facebook-github-bot
facebook-github-bot approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 10, 2018
@grabbou @facebook-github-bot
Fix Metro preset version (#21034)
5d55f03 
Summary: This pull request removes the hard-coded version of the `metro-react-native-babel-preset` as defined in the `init` command. That way, the version always matches React Native version specified in its `package.json`, making it match Metro version.

Differential Revision: D9759540

Pulled By: hramos

fbshipit-source-id: 90835442e2db1900851cbfb8c3c625229184d851
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Sep 11, 2018
@hramos
Copy link
Contributor

hramos commented Sep 13, 2018 •
edited
Loading

I don't know why this wasn't auto-closed by the bot, but it looks like this PR was imported successfully. It landed as 5d55f03.

@hramos hramos closed this Sep 13, 2018
@hramos hramos added Merged This PR has been merged. and removed Import Failed labels Sep 13, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Sep 13, 2018
@hramos hramos deleted the fix/metro-preset-ver branch February 25, 2020 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kelset kelset kelset approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@Salakar Salakar Salakar approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Missing Test Plan This PR appears to be missing a test plan.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grabbou @facebook-github-bot @Salakar @hramos @gengjiawen @kelset @react-native-bot