Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]RNTester debug break in master #22800

Closed
gengjiawen opened this issue Dec 26, 2018 · 7 comments
Closed

[Bug]RNTester debug break in master #22800

gengjiawen opened this issue Dec 26, 2018 · 7 comments
Labels
Contributor A React Native contributor. Partner Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@gengjiawen
Copy link
Contributor

gengjiawen commented Dec 26, 2018 •
edited
Loading

Looks like introduced in 1eedf05.

    Process: com.facebook.react.uiapp, PID: 3307
    java.lang.IllegalStateException: Expected a string but was BEGIN_ARRAY
        at android.util.JsonReader.nextString(JsonReader.java:408)
        at com.facebook.react.devsupport.BundleDeltaClient$BundleDeltaJavaClient.processDelta(BundleDeltaClient.java:103)
        at com.facebook.react.devsupport.BundleDeltaClient.processDelta(BundleDeltaClient.java:71)
        at com.facebook.react.devsupport.BundleDownloader.processBundleResult(BundleDownloader.java:314)
        at com.facebook.react.devsupport.BundleDownloader.access$200(BundleDownloader.java:37)
        at com.facebook.react.devsupport.BundleDownloader$1.onResponse(BundleDownloader.java:174)
        at okhttp3.RealCall$AsyncCall.execute(RealCall.java:153)
        at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)
@gengjiawen gengjiawen added the Type: Discussion Long running discussion. label Dec 26, 2018
@gengjiawen gengjiawen changed the title RNTester debug break in master [Bug]RNTester debug break in master Dec 26, 2018
gengjiawen referenced this issue Dec 26, 2018
@facebook-github-bot
Update the Delta/HMR format
1eedf05 
Summary:
Makes the delta bundle data structures more consistent.

The changes are as follows:
* There are now two types of JSON bundles that can be downloaded from the delta endpoint. Base bundles (`Bundle` type), and Delta bundles (`DeltaBundle` type).
* The `reset` boolean is renamed to `base`.
* `pre` and `post` properties are now strings.
* Only `Bundle` can define `pre` and `post` properties.
* The `delta` property is renamed to `modules`.
* Deleted modules are now listed inside of the `deleted` property, which is only defined by `DeltaBundle`.

Reviewed By: mjesun

Differential Revision: D10446831

fbshipit-source-id: 40e229a2811d48950f0bad8dd341ece189089e9b
Jyrno42 added a commit to Jyrno42/rn-geoloctest that referenced this issue Dec 26, 2018
@Jyrno42
Use rn from source
ddb0279 
Note: Currently won't run due to facebook/react-native#22800
@Jyrno42
Copy link
Contributor

Jyrno42 commented Dec 26, 2018

Also having this issue when building RN from source.

Jyrno42 added a commit to Jyrno42/rn-geoloctest that referenced this issue Jan 2, 2019
@Jyrno42
Use release build for testing
47778bb 
As a workaround to facebook/react-native#22800
@hramos
Copy link
Contributor

hramos commented Jan 11, 2019

What are the steps to reproduce this?

@gengjiawen
Copy link
Contributor Author

gengjiawen commented Jan 11, 2019 •
edited
Loading

  • npm run start.
  • launch RNTester debug version
    It will crash. Can reproduce everytime.

@empyrical @CodingItWrong We all run into this issue. Very convenient. So I am hoping we can fix this soon.

@matt-oakes
Copy link
Contributor

What is the workaround to this?

I'd like to use the RNTester app to work on a change to the React Native core, however, with this issue it's not possible to run the tester in the master branch. What is the best way around this until a fix lands?

@matt-oakes
Copy link
Contributor

Ok. After way too much messing around I found a workaround:

  1. Open the android app with no packager running so you get the red box error about no bundle.
  2. Open the developer menu and select "dev settings" at the bottom.
  3. Untick "use deltas"
  4. Start the packager and reload the app

This should really be fixed as instead of being able to jump in and make changes to the core I spent my time trying to just get the example app to run.

@osdnk
Copy link
Contributor

osdnk commented Jan 16, 2019

@matt-oakes
Thank you so much! I confirm that it helps.
Maybe it is breaking 64de0c0?

@hramos hramos added Partner Contributor A React Native contributor. and removed Core Team labels Mar 8, 2019
@cpojer cpojer mentioned this issue Mar 19, 2019
Closed
@cpojer
Copy link
Contributor

cpojer commented Mar 19, 2019

This should have been fixed in 845189c.

@cpojer cpojer closed this as completed Mar 19, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Contributor A React Native contributor. Partner Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@cpojer @matt-oakes @hramos @Jyrno42 @gengjiawen @osdnk @react-native-bot