☂️ Lean Core

[cpojer]

For the past several months we have been discussing and making progress on a project called “Lean Core”. Please read our motivation for this project. Over the years React Native has accumulated a lot of parts that are now outdated, unused or otherwise legacy. It's time to clean everything up and put the repository into a much more manageable state going forward.

This is an umbrella task intended to track all the work necessary to reach the goal of a leaner core, including work around repository reorganization. This issue is being kept up to date so new items will be added and completed ones will be (re)moved. Some of the items will spawn separate issues to track work. If you don't see a name assigned to any of the below items and you would like to help out, please volunteer in the comments and reach out to me to get started!

Components & Runtime

React Native currently comes with a large number of components, many of which are deprecated or outdated but they still part of the repository and increase the size of applications. For items in this section we are either looking to completely remove things if they are unused, or we'd like to move them either to community managed repositories or otherwise to facebookarchive. The list here is partially based on an awesome investigation by @axe-fb. The migration can be done roughly by following @matt-oakes's guide from further below: #23313 (comment)

• Remove ImageStore (@cpojer)
• Remove PushNotificationIOS (@cpojer)
• Remove AsyncStorage (@cpojer)
• Remove Slider (@cpojer)
• Remove ProgressBarAndroid (@cpojer)
• Remove ProgressViewIOS (@cpojer)
• Remove MaskedViewIOS (@cpojer)
• Remove ActionSheetIOS (@cpojer)
• Remove ImagePickerIOS (@cpojer)
• Remove Picker and PickerIOS (@cpojer)
• Remove DatePickerAndroid, DatePickerIOS (@cpojer)
• Remove ReactART (@cpojer)

Third-Party Dependencies

Over the years we have amassed a large amount of dependencies, especially JavaScript. We have also moved things out of React Native, like Metro and the react-native-cli. This means we left a large amount of tooling dependencies in our package.json, many of which will are unused by RN itself and won't be updated to the latest versions, causing the full install of React Native to be bloated. It would also be great to do an audit of all the dependencies that are used and identify which ones could be removed.

• JavaScript Dependencies
  • Check which dependencies are large and whether they can be made smaller
  • Figure out which dependencies can be upgraded to their latest versions for security fixes
  • Figure out which dependencies can be deduplicated (= reduce version mismatches) for smaller install size
• Move React Native code to external dependencies
  • Identify which JavaScript code could be better served by a third-party package instead of maintaining a copy or our own implementation

Repository Structure

Right now the React Native repository is a large repository with little organization that promotes separation of concerns. It is our goal as part of this effort to also move things into a more manageable structure. As part of this, we'd like to follow a monorepo model that consists of multiple smaller packages. This will be a gradual migration and we will only be tracking the initial work to get this off the ground.

• Provide an initial setup that works with the existing repository, with multiple packages and also plays nicely with Facebook's internal setup (@cpojer)
• TODO: Identify more work necessary in this area

Completed work

• Add deprecation message to ImageStore [Lean Core] Add deprecation notice to ImageStore #23330 (@EvanBacon)
• Move NetInfo to a community repo (@matt-oakes)
• Move ReactART to a community repo
• Write tests for NetInfo (@matt-oakes)
• Move MaskedViewIOS to a community repo (@FonDorn)
• Merge AlertIOS with Alert e2bd7db (@wellmonge)
• Move ImageEditor to a community repo (@Trancever)
• Move Slider to a community repo (@michalchudziak)
• Move ViewPagerAndroid to a community repo (@ferrannp)
• Deprecate StatusBarIOS (@dmtrKovalenko)
• Deprecate PushNotificationIOS (@rafaellincoln)
• Move AsyncStorage to a community repo (@krizzu)
• Make the new codegen folder a separate package 5ed749e (@cpojer)
• Removed VibrationIOS caf85d4 (@cpojer)
• Removed old deprecation messages a5ae7f5 (@cpojer)
• Identify all dependencies in package.json that aren't directly used in React Native chore: remove the unused packages from package.json #23428 (@nimish-gupta)
• Remove unused dependencies chore: remove the unused packages from package.json #23428 (@nimish-gupta)
• Remove SnapshotViewIOS from public React Native interface [Lean Core] Remove SnapshotViewIOS from public interface #23497 (@jdmunro)
• Remove ListView 14d9b2d (@cpojer)
• Remove SwipeableListView 14d9b2d (@cpojer)
• Move Clipboard to a community repo (@harisbaig100)
• Move SegmentedControlIOS to a community repo (@harisbaig100)
• Remove WebView from RN repo (@cpojer)
• Remove SwipeableFlatList from RN repo (@cpojer)
• Remove Geolocation from RN repo (@cpojer, @mmmulani, @axe-fb)
• Move native "TestModule" into RNTester (@ericlewis)
• Remove polyfills from open source 06cf7fa (@cpojer)
• Remove the fetch polyfill from the repo and re-use whatwg-fetch directly Remove vendored fetch polyfill, update to whatwg-fetch@3.0 #24418 (@janicduplessis)
• Deprecate and remove CheckBox (@vonovak)
• Remove ProgressBarAndroid from the repository, possibly move to community repo (@wagnermaciel)
• Move ProgressViewIOS to a community repo
• Remove NetInfo (@cpojer)
• Move CameraRoll to a community repo (@bartolkaruza)
• Move ActionSheetIOS native code to expo (@nd-02110114)
• Create a package with lint rules and prettier to be used by React Native Community (@cpojer)
• Remove ToolbarAndroid from RNTester Android [RNTester] Remove ToolbarAndroid #24999 (@ericlewis)
• Remove Map and Set polyfills (@cpojer)
• Merge DatePickerIOS and DatePickerAndroid, move to community repo (@Swaagie)
• Remove ToolbarAndroid (@cpojer)
• Merge PickerIOS with Picker, Move the merged PickerIOS/Picker component to community repo (@bartolkaruza)
• Move ImagePickerIOS to a community repo
• Remove CheckBox (@cpojer)
• TimePickerAndroid (@cpojer)
• Remove ImageEditor (@cpojer)
• Remove CameraRoll (@cpojer)
• Remove ViewPagerAndroid (@cpojer)

Click to see prior work before this issue was created

• WebView extraction
• ListView and SwipeableListView deprecations
• CLI extraction into a separate repository
• Removed BackAndroid
• Removed TabbarIOS
• Removed NavigatorIOS

[jdmunro]

@cpojer I'd like to remove SnapshotViewIOS 🔪

[krizzu]

Hey @cpojer, thanks for putting it all together!

I'm willing to tackle few issues, starting from moving AsyncStorage.

[matt-oakes]

I would be happy to help with moving NetInfo to a community repo.

Would it be best to create a personal Github repo first and then potentially migrate that to the react-native-community org once it's ready, or should we start right away with a repo in that org?

[wellmonge]

@cpojer, I'd like to help at some of this issues, could I start with "Merge AlertIOS with Alert"?

[cpojer]

That's awesome! I put your names down next to the items above.

@jdmunro can you send a PR and assign me to it? Then I can take it over and remove FB specific stuff before landing.
@krizzu and @matt-oakes I created https://github.com/react-native-community/react-native-async-storage and https://github.com/react-native-community/react-native-netinfo for you to send PRs against with all the code necessary to make them third-party modules. Ideally in the first step, you'll just take the code from the RN repo and put them in separate repos. In order to ensure it works, we could then link them back into RN as a dependency and remove the original implementation. Further down the line we can actually move it to an optional package.
@wellmonge Sounds great! I'm not sure entirely what the work will entail but maybe you can just check out the two modules and see if you can unify them?

[michalchudziak]

@cpojer I could help with moving slider 🙂

After that I can pick up something else if you’ll still need some help

[cpojer]

@michalchudziak Awesome! I created https://github.com/react-native-community/react-native-slider, please see my comment above on what to do next.

As a name for the project in package.json, please use @react-native-community/<project name>, ie. @react-native-community/slider.

[ferrannp]

@cpojer I can take ViewPagerAndroid. I think better moving it to a community repo (if you can create the repo for me, thx 😄) than just removing it because other packages around have implemented this behaviour on JS for iOS and they relay on the native one for Android.

[jainkuniya]

Hey @cpojer I would like to help by merging and moving Picker and PickerIos. :)

[cpojer]

@ferrannp created https://github.com/react-native-community/react-native-viewpager for you! See the messages above.
@jainkuniya thanks! Not exactly sure what that will look like but maybe you can see how to unify them and start sending small PRs to react native.

[wellmonge]

That's awesome! I put your names down next to the items above.

@jdmunro can you send a PR and assign me to it? Then I can take it over and remove FB specific stuff before landing.
@krizzu and @matt-oakes I created https://github.com/react-native-community/react-native-async-storage and https://github.com/react-native-community/react-native-netinfo for you to send PRs against with all the code necessary to make them third-party modules. Ideally in the first step, you'll just take the code from the RN repo and put them in separate repos. In order to ensure it works, we could then link them back into RN as a dependency and remove the original implementation. Further down the line we can actually move it to an optional package.
@wellmonge Sounds great! I'm not sure entirely what the work will entail but maybe you can just check out the two modules and see if you can unify them?

Sure! I'll do that and report to you.

[dmtrKovalenko]

Can help with StatusBarIOS and PushNotificationIOS

[matt-oakes]

@cpojer Do you have a preference for the Android package name?

Using NetInfo as an example it is currently com.facebook.react.modules.netinfo. Should we make it standard across all extracted modules with something like com.reactnativecommunity.modules.netinfo?

[kdenz]

Can I help with

• Move SegmentedControlIOS to a community repo
• Move ProgressViewIOS to a community repo

[vonovak]

I'll take the checkbox, please.