-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][Talkback] Can't focus on TextInput via double tap #24519
Comments
Same issue can be reproduced on amongst other, Facebook marketplace, the field "send message" can't be focused by double tap. |
Hello!! I had the same issue and from what I've been researching, React Native disables natively received "requests" for focus (Android). But I found a way, wrapping the TextInput in a TouchableWithoutFeedback. It went something like this:
So the focus is given by the java script code when the TouchableWithoutFeedback is clicked. The importantForAccessibility = "no" property is used to prevent TextInput from being focused with TalkBack. |
same here, I just wonder why accessibility is not being taken seriously! |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
no, the issue has not been fixed. could you add it ot the discussion? |
Is there going to be work done on this? It is basically not possible to write properly accessible apps on Android using RN until this is fixed. The work arounds posted break the navigation order, manually calling focus moves accessibility focus back to the start of the screen, so if filling out multiple text inputs fields the user has to navigate from the start back through all the ones they have filled out and then go to the next empty field. |
We encountered this in our app and I was doing some exploratory testing to understand the bug better. A workaround I found is that if I two-finger tap in the text field, I can get it to focus and bring up the keyboard. Obviously that isn't a complete fix as it's an unexpected gesture for folks who are used to how TalkBack works. |
I'm investigating an issue that sounds like it might be similar, but I'm not sure if it's exactly the same - what I'm observing is that double tap will focus the TextInput the first time, but it won't work again after dismissing the keyboard with the hardware back button. Is everyone else seeing that double tap never works? Or is this the same issue? |
Testing with a Samsung S9. Unsure if same issue, but I am seeing the following behaviour: When If the (This is a problem if there are no other inputs on the screen to "take" focus away from the input.) I believe this is consistent with what @ejanzer described.
This did not work for me. |
I'm having the exact same issue.
^ This didn't work for me.
Exact same behavior for me. Any ideas? |
I am getting the same issue, can someone look into this bug or give us a workaround? |
Just stumbled across this while doing something unrelated. But on the native side, if you set the onClickListener of the TextInputEditText to dispatch a tap or open the drawer it will behave how you want. |
So this may or may not be related to your issue but I encountered a problem where I had to multi-tap TextInput components to become focused and keyboard intermittently opened. I found out that the issue was being in debug mode. When they said it impedes performance, they weren't kidding. It seems like the performance hindered the ability to properly register taps. For reference:
|
@PeoB |
This issue has been fixed with this PR on latest RN version. Additionally for the current fix in older RN version We can add a same OnClick capabilities on TextInput by creating Custom React Element with Touchable view that inherit TextInput element with clickable props that focus the keyboard after onClick. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
The issue has not been fixed. |
I am getting the same issue. |
The issue has not been fixed. I am going through this now. |
@fabriziobertoglio1987 any update on this issue? |
@shivenmian PR #33468 (comment) includes extensive video tests of this functionality. I did not detect any issues, but I will do more tests in a couple of days. Thanks https://drive.google.com/file/d/1kAHHrYKXP6tRFf7w1_rcxOFp3cCa2L_C/view |
Main Branch 2023-01-27.15-17-23.mp4Related fabOnReact@6c4224e |
@GuilhermePortella @Bertlk @kevinrodriguez-io I could not reproduce this issue using the latest version of react-native. My test on the latest release of react-native 2023-01-27.15-44-54.mp4 |
hey @fabriziobertoglio1987 how are you? I managed to solve this problem by updating to version 0.70, thanks 😃 |
🐛 Bug Report
When using
<TextInput>
in combination with TalkBack on android you can't double tap to give the field focus. Double tap and hold on the other hand works to give focus and providing the context menu (paste, select all etc)To Reproduce
Add
<TextInput />
to your project and start TalkBack, swipe your way to the<TextInput />
and double tap. You will get a "thump" sounding sound and nothing else will happen.Android 8.0(API 26+) or greater is needed to reproduce, earlier versions everything seems to work as expected.
Expected Behavior
Focus to be set to the
TextInput
and keyboard showing.Code Example
Other
If you add an accessible view around the TextInput and you double tap that focus correctly goes to the TextInput.
Environment
The text was updated successfully, but these errors were encountered: