Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passing Flatlist prop scrollEventThrottle doesn't make sense (regression 0.59.5 -> 0.59.8) #25027

Closed
alyalya opened this issue May 24, 2019 · 4 comments
Closed

passing Flatlist prop scrollEventThrottle doesn't make sense (regression 0.59.5 -> 0.59.8) #25027

alyalya opened this issue May 24, 2019 · 4 comments
Labels
Bug Component: FlatList Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Locked This issue was locked by the bot.

Comments

@alyalya
Copy link

alyalya commented May 24, 2019

After updating React Native from 0.59.5 to 0.59.8 scrollEventThrottle in Flatlist stopped working, which resulted in ramming the bridge

React Native version:
0.59.8

Steps To Reproduce

  1. Add scrollEventThrottle prop to Flatlist
  2. Scroll Flatlist
  3. We get every scroll event in onScroll prop

Describe what you expected to happen:

Expected to get throttled scroll events

Snack, code example, or link to a repository:
@alyalya alyalya added the Bug label May 24, 2019
@react-native-bot react-native-bot added Component: FlatList Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. labels May 24, 2019
@satya164
Copy link
Contributor

Can you provide a minimal repro demonstrating the bug?

@krizzu
Copy link

krizzu commented May 30, 2019

Probably caused by this commit

@kelset
Copy link
Contributor

kelset commented May 30, 2019

I think this is a duplicate of this: #24826

Apparently there was a subsequent fix, I'm still trying to find the commit.

@zhongwuzw
Copy link
Contributor

zhongwuzw commented May 31, 2019 •
edited
Loading

@alyalya Hi, we fixed it in #25098. Please check that.

@facebook facebook locked as resolved and limited conversation to collaborators Jun 3, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Component: FlatList Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@satya164 @zhongwuzw @krizzu @kelset @alyalya @react-native-bot