Hermes emit binary crash #25609

mjmasn · 2019-07-12T10:57:24Z

When running with --variant release or doing a production build, the Hermes emit binary step fails, leaving a 0 byte bundle file. It looks like something to do with overwriting the same file, as if I cancel the build before the hermes step, then manually run the command from the Program arguments below but with a different output path, it works fine and the bytecode bundle is saved correctly.

Stack dump:
0.	Program arguments: ../../node_modules/hermesvm/linux64-bin/hermes -emit-binary -out /REDACTED/android/app/build/generated/assets/react/release/index.android.bundle /REDACTED/android/app/build/generated/assets/react/release/index.android.bundle -O -output-source-map 
1.	Program arguments: ../../node_modules/hermesvm/linux64-bin/hermes -emit-binary -out /REDACTED/android/app/build/generated/assets/react/release/index.android.bundle /REDACTED/android/app/build/generated/assets/react/release/index.android.bundle -O -output-source-map 
[0x41ba83]
[0x41abc9]
[0x41ac6c]
[0x4265e0]
[0x499f43]
[0x49a163]
[0x43d7ff]
[0x43d967]
[0x44003a]
[0x4399b2]
[0x439b32]
[0x42b8b9]
[0x4308d6]
[0x40487b]
[0x712f34]
[0x7131b1]
[0x408116]
[0x41ba83]
[0x41abc9]
[0x41ac6c]
[0x4265e0]
[0x499f43]
[0x49a163]
[0x43d7ff]
[0x43d967]
[0x44003a]
[0x4399b2]
[0x439b32]
[0x42b8b9]
[0x4308d6]
[0x40487b]
[0x712f34]
[0x7131b1]
[0x408116]

FAILURE: Build failed with an exception.

* Where:
Script '/REDACTED/android/app/react.gradle' line: 150

* What went wrong:
Execution failed for task ':app:bundleReleaseJsAndAssets'.
> Process 'command '../../node_modules/hermesvm/linux64-bin/hermes'' finished with non-zero exit value 135

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2m 57s

React Native version:

System:
    OS: Linux 4.15 Ubuntu 16.04.6 LTS (Xenial Xerus)
    CPU: (8) x64 Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
    Memory: 2.09 GB / 15.54 GB
    Shell: 4.3.48 - /bin/bash
  Binaries:
    Node: 8.11.3 - ~/.nvm/versions/node/v8.11.3/bin/node
    Yarn: 1.16.0 - /usr/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.11.3/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    Android SDK:
      API Levels: 22, 24, 26, 27, 28, 29
      Build Tools: 23.0.1, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.3, 28.0.2, 28.0.3, 29.0.0
      System Images: android-22 | Google APIs Intel x86 Atom_64, android-24 | Google APIs ARM 64 v8a, android-24 | Google APIs Intel x86 Atom, android-24 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom_64
      Android NDK: 17.1.4828580
  IDEs:
    Android Studio: 3.4 AI-183.6156.11.34.5522156
  npmPackages:
    react: 16.8.6 => 16.8.6 
    react-native: ^0.60.3 => 0.60.3 
  npmGlobalPackages:
    create-react-native-app: 2.0.2
    react-native-cli: 2.0.1
    react-native-create-library: 3.1.2
    react-native-git-upgrade: 0.2.7

Steps To Reproduce

Try creating a Hermes-enabled release build
💥

Describe what you expected to happen:
The build to succeed.

Snack, code example, or link to a repository:
Any new RN 0.60.3 app, but I made an example at https://github.com/mjmasn/HermesApp

Clone the repo
Run yarn
Run yarn start
In a second terminal window run react-native run-android --variant release
Build fails

The text was updated successfully, but these errors were encountered:

kashsbd · 2019-07-13T03:52:55Z

Hello @mjmasn , I face the same error. Do you have solution to generate signed apk with hermes engine without any errors ?

mjmasn · 2019-07-13T12:45:29Z

@B4UGUYS see the last code snippet on this #25601 (comment)

You'll need to copy react.gradle from node_modules to your android/app folder before editing it.

Replace the line starting commandLine(getHermesCommand() with my snippet.

paulovlobato · 2019-07-16T12:37:00Z

@B4UGUYS see the last code snippet on this #25601 (comment)

You'll need to copy react.gradle from node_modules to your android/app folder before editing it.

Replace the line starting commandLine(getHermesCommand() with my snippet.

Thank you @mjmasn I was having the same issue, your snipped did the trick!

zeljkoX · 2019-07-17T09:23:00Z

For me, everything works locally but executing it on CI results in a reported error. Maybe memory issues with CI.

Can Hermes memory usage, number of daemons/threads, can be limited?

giannismacheras · 2019-07-18T16:07:33Z

@mjmasn I also used your snippet and the problem was fixed, thanks! However, using the Android Studio APK Analyzer, I saw that a file called 'index.android.bundle_temp' is included in the assets directory. I guess this is related to your snippet. What can I do to fix this?

mjmasn · 2019-07-18T16:20:51Z

@luckyluke19 hmm, good point, I haven't tried this but probably something like

ant.delete(
    file: "${jsBundleFile}_temp"
);

after the hermes command?

Let me know if that works and I'll update my post. I haven't really got time to look at any more switching-to-Hermes stuff in our app at the moment.

giannismacheras · 2019-07-18T16:51:24Z

@mjmasn No, it doesn't work. It shows the initial error again (Process 'command '../../node_modules/hermesvm/linux64-bin/hermes'' finished with non-zero exit value 135)

thinhtran3588 · 2019-07-19T05:42:41Z

@luckyluke19 you should move it outside exec.
Have the same issue and got it work by moving it outside.

giannismacheras · 2019-07-19T07:11:38Z

@thinhtran3588 thanks, that worked!

nagaraj95 · 2019-07-19T11:24:55Z

@reactjs-bot @react-native-bot @mjmasn i have followed the above steps but I get an error like this

Process 'command '..\node_modules\hermesvm\win64-bin\hermes'' finished with non-zero exit value -1073741515
Please post some solution for this.Below I posted my react.gradle file

` if (enableHermes) {
doLast {
def hermesFlags;
exec {
// if (targetName.toLowerCase().contains("release")) {
if (!targetName.toLowerCase().contains("debug")) {
// Can't use ?: since that will also substitute valid empty lists
hermesFlags = config.hermesFlagsRelease
if (hermesFlags == null) hermesFlags = ["-O", "-output-source-map"]
} else {
hermesFlags = config.hermesFlagsDebug
if (hermesFlags == null) hermesFlags = []
}
commandLine(getHermesCommand(), "-emit-binary", "-out", jsBundleFile, jsBundleFile, *hermesFlags)
}
if (hermesFlags.contains("-output-source-map")) {
ant.move(
// Hermes will generate a source map with this exact name
// NOTE: name coincides with jsOutputSourceMapFile
file: "${jsBundleFile}.map",
tofile: jsCompilerSourceMapFile
);
exec {
// TODO: set task dependencies for caching

                        // Set up the call to the compose-source-maps script
                        workingDir(reactRoot)
                        if (Os.isFamily(Os.FAMILY_WINDOWS)) {
                            commandLine("cmd", "/c", *nodeExecutableAndArgs, composeSourceMapsPath, jsPackagerSourceMapFile, jsCompilerSourceMapFile, "-o", jsOutputSourceMapFile)
                        } else {
                            commandLine(*nodeExecutableAndArgs, composeSourceMapsPath, jsPackagerSourceMapFile, jsCompilerSourceMapFile, "-o", jsOutputSourceMapFile)
                        }
                    }
                }
            }
        } else {
            doLast {
                ant.move(
                    file: jsPackagerSourceMapFile,
                    tofile: jsOutputSourceMapFile
                );
            }
        }   
 def isRelease = !targetName.toLowerCase().contains("debug")

    def libDir = "$buildDir/intermediates/transforms/"
    def vmSelectionAction = {
        fileTree(libDir).matching {
            if (enableHermes) {
                // For Hermes, delete all the libjsc* files
                include "**/libjsc*.so"

                if (isRelease) {
                    // Reduce size by deleting the debugger/inspector
                    include '**/libhermes-inspector.so'
                    include '**/libhermes-executor-debug.so'
                } else {
                    // Release libs take precedence and must be removed
                    // to allow debugging
                    include '**/libhermes-executor-release.so'
                }
            } else {
                // For JSC, delete all the libhermes* files
                include "**/libhermes*.so"
            }
        }.visit { details ->
            def targetVariant = ".*/transforms/[^/]*/${targetPath}/.*"
            def path = details.file.getAbsolutePath().replace(File.separatorChar, '/' as char)
            if (path.matches(targetVariant) && details.file.isFile()) {
              details.file.delete()
            }
        }
    }

`

valery-lavrik · 2019-08-02T10:45:02Z

I have a similar error:

without text "finished with non-zero exit value"

what should I do?

valery-lavrik · 2019-08-02T11:28:16Z

./gradlew bundleRelease --info

gave such a result:
...

Task :app:bundleReleaseJsAndAssets FAILED
Caching disabled for task ':app:bundleReleaseJsAndAssets' because: Build cache is disabled
...

How to enable cache?

mjmasn · 2019-08-02T11:43:47Z

@valery-lavrik see my earlier comments #25601 (comment)

NB this was a quick temporary workaround so I could test out Hermes, the RN / Hermes team need to fix this properly.

Copy react.gradle from node_modules/react-native to android/app
In the copied react.gradle Replace the line starting commandLine(getHermesCommand(),... with:

ant.move(
    file: jsBundleFile,
    tofile: "${jsBundleFile}_temp"
);
commandLine(getHermesCommand(), "-emit-binary", "-out", jsBundleFile, "${jsBundleFile}_temp", *hermesFlags)

Below this (outside the exec section around commandLine(getHermesCommand(),...) add this:

ant.delete(
    file: "${jsBundleFile}_temp"
);

valery-lavrik · 2019-08-02T13:26:47Z

@mjmasn
I copied the react.gradle file and made changes to it:

and

but command
.\gradlew clean
and
.\gradlew --info bundleRelease
still return an error:

why?

chauhanparth210 · 2019-08-05T19:59:21Z

please anyone give solution about it.
(same thing happens to me do all the changes and at the end get error as above)

valery-lavrik · 2019-08-06T12:16:31Z

@mjmasn The solution to my problem is already in the last patch. c21e36d

But during installation, an outdated version is installed for me. Why?
http://prntscr.com/op1q42

BSoD38 · 2019-08-06T12:41:10Z

@valery-lavrik this is because the commit you've linked is available in the latest master, but is not yet available in the stable releases.

A new release containing this fix should be available soon enough.

kashsbd · 2019-08-15T04:07:12Z

I think this issue is still on react native version 0.60.5 .

valery-lavrik · 2019-08-15T06:40:32Z

@kashsbd I think so too

hemmedo · 2019-08-22T06:29:59Z

yeah it still persists.

adnkh · 2019-08-22T09:40:23Z

In my case, the building release with --variant=release is working fine, but making bundle Release for play store is not working the application just crash immediately after the splash screen
This is in 0.60.5

giannismacheras · 2019-08-22T09:46:04Z

@adnkh Exactly the same thing happened to me. I uploaded APKs instead and the problem was fixed.

hemmedo · 2019-08-22T10:21:01Z

@adnkh then why /gradlew assembleRelease isn't working? Technically they're doing the same thing. Nevertheless, I'm just gonna wait for this Hermes update to go live.

nagaraj95 · 2019-08-22T10:28:17Z

Can I know how you fixed that?

…

On Thu, Aug 22, 2019 at 3:19 PM LuckyLuke19 ***@***.***> wrote: @adnkh <https://github.com/adnkh> Exactly the same thing happened to me. I uploaded APKs instead and the problem was fixed. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25609?email_source=notifications&email_token=AECTT6G4K4XM455RNSAWKITQFZOLNA5CNFSM4ICHH52KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44QZSQ#issuecomment-523832522>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AECTT6CGQDKUFBEBGSFXG7LQFZOLNANCNFSM4ICHH52A> .

-- Thanks and with regards, * Nagaraj.R*

giannismacheras · 2019-08-22T10:36:05Z

@nagaraj95 instead of running ./gradlew bundleRelease to generate an AAB file, I ran ./gradlew assembleRelease and generated APK files. Is that what you mean?

nagaraj95 · 2019-08-22T11:16:09Z

I ran this command only gradlew assembleRelease and got error like that only

…

On Thu, Aug 22, 2019 at 4:09 PM LuckyLuke19 ***@***.***> wrote: @nagaraj95 <https://github.com/nagaraj95> instead of running ./gradlew bundleRelease to generate an AAB file, I ran ./gradlew assembleRelease and generated APK files. Is that what you mean? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25609?email_source=notifications&email_token=AECTT6CMSXONJE3XBS6LW5DQFZUGLA5CNFSM4ICHH52KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44UXFI#issuecomment-523848597>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AECTT6FYJK2BURHE4PLACZ3QFZUGLANCNFSM4ICHH52A> .

-- Thanks and with regards, * Nagaraj.R*

hemmedo · 2019-08-22T11:22:36Z

@luckyluke19 ./gradlew assembleRelease doesnt work for us. What did you do to get it working?

giannismacheras · 2019-08-22T13:40:31Z

@hemmedo, @nagaraj95
If you are getting an error about hermes, try this: #25609 (comment)

aecorredor · 2019-08-26T04:11:45Z

@zeljkoX same thing happens to me. Runs fine locally but crashes running on CircleCI. Did you find a fix?

zeljkoX · 2019-08-26T07:12:02Z

@aecorredor I haven't.

rksh1997 · 2019-08-30T06:52:47Z

I am still having this problem with 0.60.5

TheChanDI · 2019-08-30T16:00:12Z

having issue for 0.60.4

yanqiqi1996 · 2019-09-02T08:13:39Z

@mjmasn
I copied the react.gradle file and made changes to it:

and

but command
.\gradlew clean
and
.\gradlew --info bundleRelease
still return an error:

why?

I follow you ，it‘s ok in 0.60.5

valery-lavrik · 2019-09-02T08:23:08Z

@yanqiqi1996

I follow you ，it‘s ok in 0.60.5

you did it in win10?
I think the problem is in win10.

vitalyiegorov · 2019-09-02T13:53:46Z

Same error building with gitlab-ci, locally works perfectly, rn 0.60.5

LydGol90 · 2019-09-03T10:10:05Z

@zeljkoX @vitalyiegorov I am seeing the same issue as you, I use circleci. I have tried various ways to reduce java heap size and such and it doesn't seem to be related to that. The only difference I can see for me is that locally I run on mac OS and in circleci I use the an android-node docker image. I assume that means that locally it uses 'node_modules/hermesvm/osx-bin/hermes' whereas on circleci uses 'node_modules/hermesvm/linux64-bin/hermes' so I'm guesssing the issue is related to that. Was wondering whether you guys are also building on mac locally?

vitalyiegorov · 2019-09-03T11:30:18Z

@LydGol90 absolutely, using mac locally, trying to setup appcenter.ms right now - seems to have successful build there.

zeljkoX · 2019-09-03T14:15:42Z

@LydGol90
Also, using mac locally, docker image for android on CircleCI.

sunnylqm · 2019-09-24T03:33:40Z

This should be fixed in facebook/hermes#45 and will be included in 0.61

leaky · 2019-09-26T10:52:48Z

If you're building your android app using RN 0.60. x on CircleCI and Linux, you can set enableHermes: false in android/app/build.gradle:80 to disable the Hermes JS engine and prevent this error until the issue is patched by FB.

ammarRajabA · 2019-11-13T07:47:53Z

@valery-lavrik see my earlier comments #25601 (comment)

NB this was a quick temporary workaround so I could test out Hermes, the RN / Hermes team need to fix this properly.

Copy react.gradle from node_modules/react-native to android/app

In the copied react.gradle Replace the line starting commandLine(getHermesCommand(),... with:
ant.move(
    file: jsBundleFile,
    tofile: "${jsBundleFile}_temp"
);
commandLine(getHermesCommand(), "-emit-binary", "-out", jsBundleFile, "${jsBundleFile}_temp", *hermesFlags)
Below this (outside the exec section around commandLine(getHermesCommand(),...) add this:
ant.delete(
    file: "${jsBundleFile}_temp"
);

@mjmasn ,thanks for your contribution, but I have a question, should I move react.gradle back to the node_modules folder where it was because I see same error after the changes.

mjmasn · 2019-11-13T08:21:56Z

@ammarRajabA there's a line something like:

apply from: "../../node_modules/react-native/react.gradle"

in android/app/build.gradle

You should update that to point to the new file. Moving the react.gradle back to node_modules would only work temporarily, as it would be overwritten when node_modules are installed.

I haven't tried the latest RN releases with Hermes so I have no idea if these workarounds are still necessary. Would be surprised if it hadn't been fixed by now... 🤔

ruslan-hontar · 2020-02-03T16:13:08Z

Copy react.gradle from ../../node_modules/react-native/ to ./android/app/
Change apply from: "../../node_modules/react-native/react.gradle" to apply from: "./react.gradle" in android/app/build.gradle
In react.gradle add

def hbcTempFile = file("${jsBundleFile}.hbc")

after def hermesFlags;, change

commandLine(getHermesCommand(), ... )

to

commandLine(getHermesCommand(), "-emit-binary", "-out", hbcTempFile, jsBundleFile, *hermesFlags)

after exec {...} add

ant.move(
  file: hbcTempFile,
  toFile: jsBundleFile
);

In android/build.gradle/ add

    configurations.all {
        resolutionStrategy {
            force "com.facebook.soloader:soloader:0.8.0"
        }
    }

Now I can upload bundle build to Google Play and it doesn't crash after splash screen.

stale · 2020-05-03T16:58:17Z

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

stale · 2020-05-10T17:19:47Z

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

mjmasn added the Bug label Jul 12, 2019

react-native-bot added the Platform: Linux Building on Linux. label Jul 12, 2019

mjmasn mentioned this issue Jul 12, 2019

[0.60.3] App crash on startup when enabling Hermes (enableHermes: true) #25601

Closed

react-native-bot added the Tech: Hermes Hermes Engine: https://hermesengine.dev/ label Jul 17, 2019

giannismacheras mentioned this issue Jul 19, 2019

[0.60.4] Generating the release APK when enabling Hermes #25726

Closed

stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label May 3, 2020

stale bot closed this as completed May 10, 2020

facebook locked as resolved and limited conversation to collaborators May 11, 2020

Hermes emit binary crash #25609

Hermes emit binary crash #25609

Comments

mjmasn commented Jul 12, 2019

Steps To Reproduce

kashsbd commented Jul 13, 2019

mjmasn commented Jul 13, 2019 • edited Loading

paulovlobato commented Jul 16, 2019

zeljkoX commented Jul 17, 2019 • edited Loading

giannismacheras commented Jul 18, 2019

mjmasn commented Jul 18, 2019 • edited Loading

giannismacheras commented Jul 18, 2019

thinhtran3588 commented Jul 19, 2019

giannismacheras commented Jul 19, 2019

nagaraj95 commented Jul 19, 2019 • edited Loading

valery-lavrik commented Aug 2, 2019

valery-lavrik commented Aug 2, 2019

mjmasn commented Aug 2, 2019

valery-lavrik commented Aug 2, 2019

chauhanparth210 commented Aug 5, 2019 • edited Loading

valery-lavrik commented Aug 6, 2019 • edited Loading

BSoD38 commented Aug 6, 2019

kashsbd commented Aug 15, 2019

valery-lavrik commented Aug 15, 2019

hemmedo commented Aug 22, 2019

adnkh commented Aug 22, 2019

giannismacheras commented Aug 22, 2019

hemmedo commented Aug 22, 2019

nagaraj95 commented Aug 22, 2019 via email

giannismacheras commented Aug 22, 2019

nagaraj95 commented Aug 22, 2019 via email

hemmedo commented Aug 22, 2019

giannismacheras commented Aug 22, 2019

aecorredor commented Aug 26, 2019

zeljkoX commented Aug 26, 2019

rksh1997 commented Aug 30, 2019

TheChanDI commented Aug 30, 2019

yanqiqi1996 commented Sep 2, 2019

valery-lavrik commented Sep 2, 2019

vitalyiegorov commented Sep 2, 2019 • edited Loading

LydGol90 commented Sep 3, 2019

vitalyiegorov commented Sep 3, 2019

zeljkoX commented Sep 3, 2019

sunnylqm commented Sep 24, 2019

leaky commented Sep 26, 2019

ammarRajabA commented Nov 13, 2019

mjmasn commented Nov 13, 2019

ruslan-hontar commented Feb 3, 2020 • edited Loading

stale bot commented May 3, 2020

stale bot commented May 10, 2020

mjmasn commented Jul 13, 2019 •

edited

Loading

zeljkoX commented Jul 17, 2019 •

edited

Loading

mjmasn commented Jul 18, 2019 •

edited

Loading

nagaraj95 commented Jul 19, 2019 •

edited

Loading

chauhanparth210 commented Aug 5, 2019 •

edited

Loading

valery-lavrik commented Aug 6, 2019 •

edited

Loading

vitalyiegorov commented Sep 2, 2019 •

edited

Loading

ruslan-hontar commented Feb 3, 2020 •

edited

Loading