Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AnimatedMock don't call animation end callback #25615

Closed
slgarkea opened this issue Jul 12, 2019 · 2 comments
Closed

New AnimatedMock don't call animation end callback #25615

slgarkea opened this issue Jul 12, 2019 · 2 comments
Labels
API: Animated Bug Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@slgarkea
Copy link

slgarkea commented Jul 12, 2019

This commit (45686c8#diff-35653b5f6360716ec796e5ffdd483841) introduce a mock mode for React Native Animated module. This mode is activated when you build your ios application with the Debug target.

However, we use the onModalShow and onModalHide (from react-native-modal) in order to navigate through our application. Those functions are called when the animation's start callback is called. The mock mode doesn't execute the callback and broke the normal behaviour.

I tried some fixes but I can't make it work properly.
Thanks for your help.

--

React Native version:
info
React Native Environment Info:
System:
OS: macOS 10.14.3
CPU: (4) x64 Intel(R) Core(TM) i7-4578U CPU @ 3.00GHz
Memory: 245.47 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.13.0 - /usr/local/bin/node
Yarn: 1.15.2 - /usr/local/bin/yarn
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 19, 21, 22, 23, 24, 25, 26, 27, 28
Build Tools: 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.3, 28.0.2, 28.0.3
System Images: android-22 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.5429.30.34.5452501
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.10 => 0.59.10

@stale
Copy link

stale bot commented Oct 10, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 10, 2019
@stale
Copy link

stale bot commented Oct 17, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Oct 17, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API: Animated Bug Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
2 participants