-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(AnimatedMock): make mocks .start callback async + implemented on all animations #31992
test(AnimatedMock): make mocks .start callback async + implemented on all animations #31992
Conversation
Hi @Michael-M-Judd! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: 91cac20 |
Base commit: 91cac20 |
it('calls the start callback', () => { | ||
AnimatedMock.parallel([]).start(mockStartCallback); | ||
|
||
jest.runAllTimers(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we call runAllTimers twice? Do we need to call it in the test if its part of itCallsStartCallback
?
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Summary
When mocked
Animated
using theAnimatedMock
, I noticed a few things that were off with the mocks that weren't happening with real code:.start()
synchronously. I've changed this to make it async so that it's more like the realAnimated
behaviour.parallel
,.decay
,.stagger
,.sequence
, and.loop
all used theemptyAnimation
object which doesn't implement the.start(cb)
callback like timing/spring do.This should also fix #25615
Changelog
[General] [Fixed] - AnimatedMock
.parallel
,.stagger
,.sequence
,.loop
now correctly call the callback passed to.start
[General] [Fixed] - All AnimatedMock .start callback methods are now called async instead of synchronously to better simulate the production environment
Test Plan