Layout inconsistency between Switch & SwitchAndroid

[christopherdro]

Switch

SwitchAndroid

The width value here seems to be incorrect.
https://github.com/facebook/react-native/blob/master/Libraries/Components/Switch/Switch.js#L113

No exactly sure if this applies to all devices so I wanted to check before making any kind of PR.

[brentvatne]

@christopherdro - images seem to be broken :O could you update?

[christopherdro]

@brentvatne loads for me on mobile

[christopherdro]

So there are a couple ways this can be fixed but wanted to get some feedback before submitted a PR. After talking to @mkonicek this last week at Reactive2015 he mentioned that size of the switch for android is calculated automatically whereas it need to be defined for IOS.

So I'm wondering if we should remove this section entirely

react-native/Libraries/Components/Switch/Switch.js

Lines 111 to 114 in 2c7de35

	rctSwitchAndroid: {
	height: 27,
	width: 40,
	},

, and then remove props.style = [styles.rctSwitchAndroid, this.props.style]; or alter it to props.style = this.props.style;

[mkonicek]

This looks like a bug, thanks for reporting!

@sahrens I think the fixed size was added as part of the universal Switch and SwitchAndroid doesn't do that? Can we remove this?

react-native/Libraries/Components/Switch/Switch.js

Lines 111 to 114 in 2c7de35

	rctSwitchAndroid: {
	height: 27,
	width: 40,
	},