[Navigator] pop animations hang and lag slowly in 0.14.2

[jforaker]

https://www.dropbox.com/s/6ze2xllvmzrrk79/2015_11_15_16_45_56.mp4?dl=0

Ever since upgrade to 0.14.2, Navigator pop() animations hang and look laggy overall. As you can see in the video the view being popped "hangs" for noticeably too long, then abruptly disappears. This is not ideal and seems like a regression in terms of performance, and or is a definite bug.

Yes it is Genymotion, yes dev mode is false, tested on brand new Nexus 5x - same thing. It was flawless before in 0.13.x
(Disregard the animation lag in the view pushes, I'll chalk that up to the emulator performance. Just pay attention to the back arrow clicks and the 'X' button clicks)

First view being pushed is:

sceneConfig: Navigator.SceneConfigs.FloatFromBottom

Second one is:

Navigator.SceneConfigs.FloatFromRight

[praisegeek]

It seems to affect Scene Configs with longer transitions.
You can use Navigator.SceneConfigs.FadeAndroid for now until a fix has been made.

[brentvatne]

cc @mkonicek this is an example of where offloading animations is good ;)

[brentvatne]

Not seeing any changes to Navigator.js that landed in 0.14 that would have impacted this. Are you sure that this was the only change that you made? Are you not maybe running some code in response to navigator focus events?

[jforaker]

Can you elaborate on what you mean by "navigator focus events"?

[brentvatne]

https://facebook.github.io/react-native/docs/navigator.html#ondidfocus

[jforaker]

Definitely not, never used that before. As far as I understand, I am just doing simple pushes and pops, and passing in sceneConfig to mix it up the animations for the user.

[satya164]

Is this fixed in master? Cause this is there in 0.15.0-rc

The relevant issue - #3669

[brentvatne]

Thanks for additional context @satya164! Are you guys only experiencing this on Android?

[satya164]

@brentvatne I've not tested on iOS yet.

[brentvatne]

@mkonicek - are you seeing this at all internally? not sure who should be assigned

[jforaker]

Same, not tested on iOS for me.

Here is a higher res/better video showing the problem: https://www.dropbox.com/s/6ze2xllvmzrrk79/2015_11_15_16_45_56.mp4?dl=0

Also note the crazy angled animation on the last view that occurs with:

sceneConfig: Navigator.SceneConfigs.VerticalUpSwipeJump

[ramilushev]

+1 I can confirm this is happening on Android. Just simple push and pop, nothing else. Could this be a problem with animating the opacity?

[kmagiera]

This issue should be fixed in 0.16 as of #3954. @jforaker, would you be able to verify that on your app and close this issue? Thanks!

[jforaker]

Installing react-native@latest (which was 0.16.0-rc) did not work at all for me, see #4488 (comment).

When using 0.16.0-rc:
TypeError: expected dynamic type 'double', but had type 'boolean' (constructing arguments for RCTNetworking.sendRequest at argument index 5)

0.15.0 is the most recent version that I can actually get to run successfully without red screen errors on start. Therefore I cannot say if this issue is fixed or not.

Is there a way to install this specific "version" that I am unaware of? Installing a library at a certain pull request is not the most straightforward thing to do...

@satya164 - have you got it to work? Or have you seen the transition animations be fixed in your app?

[satya164]

@jforaker I cannot upgrade to RN to 0.16.0-rc due to babel issues #4327

But if I cherry-pick b12117a, then the issue goes away.

[satya164]

Closing this since this has been fixed with b12117a