Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.16] Things we should cherry-pick to 0.16 #4327

Closed
7 of 10 tasks
mkonicek opened this issue Nov 24, 2015 · 23 comments
Closed
7 of 10 tasks

[0.16] Things we should cherry-pick to 0.16 #4327

mkonicek opened this issue Nov 24, 2015 · 23 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@mkonicek
Copy link
Contributor

0.16.0-rc has been published to npm. Here are the things we should get into 0.16.0:

We should eventually also figure out what's up with react-native bundle: #3948 (have little context). Update, fixed in 0.16.0-rc in 9a64f17. Thank you @ide!

@skevy
Copy link
Contributor

skevy commented Nov 24, 2015

@mkonicek where was the regression on the imports issue?

@mkonicek
Copy link
Contributor Author

@skevy It was somewhere in the big upgrade to Babel 6. Added a note here: https://github.com/facebook/react-native/blob/master/breaking-changes.md

@ide
Copy link
Contributor

ide commented Nov 24, 2015

We should also put out a warning about decorators if Babel support doesn't land in time. Any project with decorators in babelrc must wait for https://phabricator.babeljs.io/T2645 before upgrading to 0.16.

@skevy
Copy link
Contributor

skevy commented Nov 24, 2015

@ide 👍 I use decorators everywhere...as do you I think :)

@mkonicek
Copy link
Contributor Author

@satya164
Copy link
Contributor

I had to migrate my projects to move away from decorators. I love decorators, but there is this bug with Babel 6, and Flow doesn't support decorators either :(

@satya164
Copy link
Contributor

We should also cherry-pick this - #4298

It's a fairly small fix for the annoyance where the Switch gets cut off in Android.

@dlindahl
Copy link

Adding a note about the babelHelpers.interopRequireDefault is not a function error being caused by "Make imports work" because it is nearly impossible to discover this issue through a GitHub search or Googling it. I only found this due to a Twitter search of all places.

@satya164
Copy link
Contributor

@dlindahl That commit fixes the issue, not cause it.

@dlindahl
Copy link

@satya164 👍 My comment is just a bit of SEO so that others can find this issue if they encounter the babelHelpers.interopRequireDefault is not a function error like I did.

@satya164
Copy link
Contributor

@dlindahl Nice. The wording can confuse them though. Would be great if you can reword it.

@dlindahl
Copy link

Re-word my comment?

@satya164
Copy link
Contributor

@dlindahl Yeah, to make it clear that that commit fixes the issue.

@skevy
Copy link
Contributor

skevy commented Nov 29, 2015

@mkonicek looks like #T2694 is fixed in Babel.

@362228416
Copy link

I also encountered such a problem, how to solve

@satya164
Copy link
Contributor

We should also cherry pick c929e15

@mkonicek
Copy link
Contributor Author

mkonicek commented Dec 2, 2015

@satya164 Added it to the summary above.

@mkonicek
Copy link
Contributor Author

mkonicek commented Dec 2, 2015

Has anyone else seen Chrome debugging not working? Just tried and works for me in 0.16.0-rc: #4418

@satya164
Copy link
Contributor

satya164 commented Dec 3, 2015

@mkonicek Thanks :D

@mkonicek
Copy link
Contributor Author

mkonicek commented Dec 7, 2015

0.16 is out, closing.

@mkonicek mkonicek closed this as completed Dec 7, 2015
@mkonicek
Copy link
Contributor Author

mkonicek commented Dec 7, 2015

Working on Dialogs.

@skevy
Copy link
Contributor

skevy commented Dec 7, 2015

Question, on Babel's issue tracker, T2694 is closed. Looks like it was release in Babel 6.2.2.

I noticed that it wasn't checked off here...was it not fixed?

@gradddev
Copy link

gradddev commented Dec 7, 2015

Android WebView?

@satya164 satya164 added Release and removed Release labels Jul 14, 2016
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

8 participants