[Touches] Translated components receive touches at their non-translated position

[ide]

When translating a View on Android (0.14.0-dev), it continues to receive touches at its original position which is probably not what you want. Here's the repro with PanResponderExample in the UIExplorer (you need to touch the top-left of the scene to move the circle):

diff --git a/Examples/UIExplorer/PanResponderExample.js b/Examples/UIExplorer/PanResponderExample.js
index c2e6a66..f469439 100644
--- a/Examples/UIExplorer/PanResponderExample.js
+++ b/Examples/UIExplorer/PanResponderExample.js
@@ -53,8 +53,10 @@ var PanResponderExample = React.createClass({
     this._previousTop = 84;
     this._circleStyles = {
       style: {
-        left: this._previousLeft,
-        top: this._previousTop
+        transform: [
+          { translateY: this._previousTop },
+          { translateX: this._previousLeft },
+        ],
       }
     };
   },
@@ -112,8 +114,10 @@ var PanResponderExample = React.createClass({
     this._highlight();
   },
   _handlePanResponderMove: function(e: Object, gestureState: Object) {
-    this._circleStyles.style.left = this._previousLeft + gestureState.dx;
-    this._circleStyles.style.top = this._previousTop + gestureState.dy;
+    this._circleStyles.style.transform = [
+      { translateY: this._previousTop + gestureState.dy },
+      { translateX: this._previousLeft + gestureState.dx },
+    ];
     this._updatePosition();
   },
   _handlePanResponderEnd: function(e: Object, gestureState: Object) {

[ide]

cc @mkonicek @kmagiera is this simply how Android behaves? I can use absolute positioning instead, but if it's possible for RN to fix this in a nice way, that would be great too.

[PhilippKrone]

Ah
@ide is this basically the reason for expo/react-native-invertible-scroll-view#16?

[ide]

Yeah I think so. It might just be Android clowniness but perhaps RN is doing something to disable hitbox translation or can change this behavior on Android.

[mkonicek]

Interesting, thanks for reporting it. @andreicoman11 do you think it's related to the issue where touch coordinates are absolute instead of relative on Android?

[satya164]

This regression was introduced in c805157

[mkonicek]

@dmmiller Is now working on making the payload of touch events consistent between iOS and Android.

[PhilippKrone]

@dmmiller thanks a lot! :)

[PhilippKrone]

@dmmiller Sorry to ask again, but is there any ETA on this? Or any hotfix I could test?

[satya164]

@PhilippKrone Currently I've reverted the commit I've linked to and building from source. I needed to use adjustResize for the keyboard since reverting the commit re-surfaces the bug where touch points will be wrong if view is moved up due to keyboard focus. Really waiting for the fix.

[PhilippKrone]

@satya164 OK, I understand. I'm currently checking whether the following PR by @dmmiller might fix this issue: 0c2ee5d, but it seems not to. :(

[PhilippKrone]

I've now implemented this fix but the issue is not gone yet.

[satya164]

@PhilippKrone Which fix?

[PhilippKrone]

@satya164 Sorry, I guess the message didnt come through: 0c2ee5d

[dmmiller]

I have a fix internally that I should be pushing in the next day or so.

[ide]

@dmmiller thanks for the update. Much appreciated I'm sure.

[dmmiller]

@PhilippKrone @satya164 That fix you mentioned was not a fix for this issue. That fix fixed the values passed in the touch events to be local to the targeted view. The fix for this is currently in review and is explicitly for transformed views.

[satya164]

@dmmiller Looking forward to the fix. Thanks a lot :)

[satya164]

@dmmiller Would be totally awesome if we could get it to 0.16.0 #4327

[PhilippKrone]

@dmmiller Anything new concerning this fix for transformed views?

[dmmiller]

Waiting on @andreicoman11 to get back from holiday and accept it :) He should be back today so hopefully, we can get it pushed today.

[satya164]

@dmmiller That would be awesome. Thank you :D