Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3rd party libraries with name starting with 'a' are breaking Android project evaluation #41620

Closed
cortinico opened this issue Nov 23, 2023 · 1 comment
Closed

3rd party libraries with name starting with 'a' are breaking Android project evaluation #41620

cortinico opened this issue Nov 23, 2023 · 1 comment
Assignees
@cortinico
Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: PR Submitted A pull request with a fix has been provided.

Comments

@cortinico
Copy link
Contributor 

          This will not work if the 3rd party librariy's name is before the 'app', such as 'aliyun' .....,

How can I fix it? @gabrieldonadel ,@cortinico

Originally posted by @liuzetan in #41085 (comment)
@github-actions github-actions bot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Nov 23, 2023
@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
@cortinico cortinico self-assigned this Nov 23, 2023
@cortinico cortinico added Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Bug and removed Bug Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Nov 23, 2023
@cortinico cortinico mentioned this issue Nov 23, 2023
Closed
cortinico added a commit to cortinico/react-native that referenced this issue Nov 23, 2023
@cortinico @facebook-github-bot
Fix projects being broken on dependencies starting with a..
f59add6 
Summary:
Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes facebook#41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Differential Revision: D51547294
@cortinico cortinico added the Resolution: PR Submitted A pull request with a fix has been provided. label Nov 23, 2023
This was referenced Nov 23, 2023
Closed
Closed
cortinico added a commit to cortinico/react-native that referenced this issue Nov 23, 2023
@cortinico @facebook-github-bot
Fix projects being broken on dependencies starting with a.. (facebo…
15fe905 
…ok#41621)

Summary:

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes facebook#41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294
cortinico added a commit to cortinico/react-native that referenced this issue Nov 23, 2023
@cortinico @facebook-github-bot
Fix projects being broken on dependencies starting with a.. (facebo…
14d0e87 
…ok#41621)

Summary:

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes facebook#41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294
cortinico added a commit that referenced this issue Nov 24, 2023
@cortinico
Fix projects being broken on dependencies starting with a.. (#41621)
19be378 
Summary:
Pull Request resolved: #41621

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes #41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294

fbshipit-source-id: 65df7149548b7087dd8928e556fb803b3baf7b79
cortinico added a commit that referenced this issue Nov 24, 2023
@cortinico
Fix projects being broken on dependencies starting with a.. (#41621)
975d2b6 
Summary:
Pull Request resolved: #41621

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes #41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294

fbshipit-source-id: 65df7149548b7087dd8928e556fb803b3baf7b79
huntie pushed a commit that referenced this issue Nov 27, 2023
@cortinico @huntie
Fix projects being broken on dependencies starting with a.. (#41621)
f3f75e8 
Summary:
Pull Request resolved: #41621

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes #41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294

fbshipit-source-id: 65df7149548b7087dd8928e556fb803b3baf7b79
Othinn pushed a commit to Othinn/react-native that referenced this issue Jan 9, 2024
@cortinico @Othinn
Fix projects being broken on dependencies starting with a.. (facebo…
ea856b8 
…ok#41621)

Summary:
Pull Request resolved: facebook#41621

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes facebook#41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294

fbshipit-source-id: 65df7149548b7087dd8928e556fb803b3baf7b79
yayvery pushed a commit to discord/react-native that referenced this issue Jan 14, 2024
@cortinico @yayvery
Fix projects being broken on dependencies starting with a.. (facebo…
c93165b 
…ok#41621)

Summary:
Pull Request resolved: facebook#41621

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes facebook#41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294

fbshipit-source-id: 65df7149548b7087dd8928e556fb803b3baf7b79
yayvery pushed a commit to discord/react-native that referenced this issue Jan 14, 2024
@cortinico @yayvery
Fix projects being broken on dependencies starting with a.. (facebo…
09451a9 
…ok#41621)

Summary:
Pull Request resolved: facebook#41621

Currently, if you have a dependency that is alphabetically smaller than `app`, it's evaluation will happen before `app`.
This means that the namespace auto-discovery and the JVM toolchain configuration won't be working and the project will fail to buid.

This fixes it by introducing a root-project Gradle Plugin that takes care of enforcing the evaluation order on the `app` project.

Fixes facebook#41620

Changelog:
[Android] [Fixed] - Fix projects being broken on dependencies starting with `a..`

Reviewed By: huntie

Differential Revision: D51547294

fbshipit-source-id: 65df7149548b7087dd8928e556fb803b3baf7b79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cortinico cortinico

Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Resolution: PR Submitted A pull request with a fix has been provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix projects being broken on dependencies starting with a.. cortinico/react-native
1 participant
@cortinico