"Loading from Metro" banner rendering twice and remaining visible for ~15 seconds on each reload

[brentvatne]

Description

It looks like the loading "Loading from Metro" banner is rendered twice on each app reload (when you press r), and it takes about 15 seconds for the second banner to disappear. Reproduced on a new project with rc.6 created using https://gist.github.com/cipolleschi/82b7a9561b8861330efabbd3eb08c6f5. More details below.

Steps to reproduce

1. Clone https://github.com/brentvatne/repro-metro-loading-status (or, alternatively, create a new repo as documented in "Test Your Library against React Native 0.74.0-rcs." - that is exactly the process used for creating this repro).
2. Install deps as outlined in the library testing doc:

cd ios
bundle install
RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
open AppLibTest.xcworkspace
cd ../..
yarn start

3. Build and run for iOS (Xcode or through RNC CLI, your choice)
4. When the app is running, press r to reload it, and observe as the banner rudely overstays its welcome

React Native Version

0.74.0-rc.6

Affected Platforms

Runtime - iOS

Areas

Fabric - The New Renderer, TurboModule - The New Native Module System, Bridgeless - The New Initialization Flow

Output of npx react-native info

System:
  OS: macOS 14.3.1
  CPU: (12) arm64 Apple M3 Pro
  Memory: 346.77 MB / 36.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.12.0
    path: ~/.nvm/versions/node/v20.12.0/bin/node
  Yarn:
    version: 1.22.21
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.5.0
    path: ~/.nvm/versions/node/v20.12.0/bin/npm
  Watchman:
    version: 2024.03.25.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.4
      - iOS 17.4
      - macOS 14.4
      - tvOS 17.4
      - visionOS 1.1
      - watchOS 10.4
  Android SDK:
    API Levels:
      - "34"
    Build Tools:
      - 33.0.1
      - 34.0.0
    System Images:
      - android-34 | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2023.2 AI-232.10227.8.2321.11479570
  Xcode:
    version: 15.3/15E204a
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.10
    path: /usr/bin/javac
  Ruby:
    version: 2.7.8
    path: /Users/brent/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.0-rc.6
    wanted: 0.74.0-rc.6
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

n/a

Reproducer

https://github.com/brentvatne/repro-metro-loading-status

Screenshots and Videos

New arch enabled

Screen_Recording_2024-04-04_at_5.55.23_PM.mov

New arch disabled

Screen_Recording_2024-04-04_at_5.55.23_PM.mov

[cortinico]

✅ Picked, this will land in 0.74 RC8