Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatList Clipping Issue on iOS with New Architecture Enabled #44683

Closed
zcmgyu opened this issue May 27, 2024 · 2 comments
Closed

FlatList Clipping Issue on iOS with New Architecture Enabled #44683

zcmgyu opened this issue May 27, 2024 · 2 comments
Labels
Component: FlatList Needs: Triage 🔍 Platform: iOS iOS applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)

Comments

@zcmgyu
Copy link

zcmgyu commented May 27, 2024

Description

After enabling the New Architecture in a React Native project, a FlatList component is clipped by its container despite the overflow style being set to visible. This issue does not occur when the New Architecture is disabled, and the FlatList renders correctly. Additionally, the problem does not manifest on Android, even with the New Architecture enabled.

Steps to reproduce

  1. Clone the provided reproduction project.
  2. Execute the command: RCT_NEW_ARCH_ENABLED=1 npx pod-install.
  3. Execute the command: yarn start.
  4. Execute the command: yarn ios.
  5. Swipe list left to notice the clipping issue

React Native Version

0.74.1

Affected Platforms

Runtime - iOS

Areas

Fabric - The New Renderer

Output of npx react-native info

System:
  OS: macOS 14.5
  CPU: (11) arm64 Apple M3 Pro
  Memory: 121.23 MB / 18.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 21.6.1
    path: ~/.nvm/versions/node/v21.6.1/bin/node
  Yarn:
    version: 3.6.4
    path: ~/.nvm/versions/node/v21.6.1/bin/yarn
  npm:
    version: 10.2.4
    path: ~/.nvm/versions/node/v21.6.1/bin/npm
  Watchman:
    version: 2024.05.06.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/hc794/.gem/ruby/3.3.0/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK:
    API Levels:
      - "28"
      - "33"
      - "34"
    Build Tools:
      - 30.0.3
      - 33.0.0
      - 34.0.0
    System Images:
      - android-34 | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2023.3 AI-233.14808.21.2331.11709847
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Home/bin/javac
  Ruby:
    version: 3.3.0
    path: /Users/hc794/.rubies/ruby-3.3.0/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.1
    wanted: 0.74.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

Empty

Reproducer

https://github.com/zcmgyu/rn-overflow-bug-reproducer

Screenshots and Videos

iOS Old Arch: OK

iOS.Old.Arch.mp4

iOS New Arch: NG

iOS.New.Arch.mp4

Android New Arch: OK

Android.New.Arch.webm
@zcmgyu zcmgyu added Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels May 27, 2024
realsoelynn added a commit to realsoelynn/react-native that referenced this issue May 29, 2024
Summary:
Changelog: [Internal]

In Fabric, overflow props for ScrollView is not passed down. Hence, the overflow props is ignored and FlatList content is always clipped.

Reported from OSS facebook#44683

Differential Revision: D57895399
realsoelynn added a commit to realsoelynn/react-native that referenced this issue May 29, 2024
…book#44699)

Summary:

Changelog: [Internal]

In Fabric, overflow props for ScrollView is not passed down. Hence, the overflow props is ignored and FlatList content is always clipped.

Reported from OSS facebook#44683

Differential Revision: D57895399
realsoelynn added a commit to realsoelynn/react-native that referenced this issue May 29, 2024
…book#44699)

Summary:

Changelog: [Internal]

In Fabric, overflow props for ScrollView is not passed down. Hence, the overflow props is ignored and FlatList content is always clipped.

Reported from OSS facebook#44683

Reviewed By: sammy-SC

Differential Revision: D57895399
facebook-github-bot pushed a commit that referenced this issue May 29, 2024
Summary:
Pull Request resolved: #44699

Changelog: [Internal]

In Fabric, overflow props for ScrollView is not passed down. Hence, the overflow props is ignored and FlatList content is always clipped.

Reported from OSS #44683

Reviewed By: sammy-SC

Differential Revision: D57895399

fbshipit-source-id: 6ce65bea0803971060e8229b66563123dd6fc114
@realsoelynn
Copy link
Contributor

Fix just got merged. This fix will be part of next 0.74 patch release

@longnguyen2508
Copy link

@realsoelynn Oh, Thank you for promptly addressing the issue

kosmydel pushed a commit to kosmydel/react-native that referenced this issue Jun 11, 2024
…book#44699)

Summary:
Pull Request resolved: facebook#44699

Changelog: [Internal]

In Fabric, overflow props for ScrollView is not passed down. Hence, the overflow props is ignored and FlatList content is always clipped.

Reported from OSS facebook#44683

Reviewed By: sammy-SC

Differential Revision: D57895399

fbshipit-source-id: 6ce65bea0803971060e8229b66563123dd6fc114
Titozzz pushed a commit that referenced this issue Jun 18, 2024
Summary:
Pull Request resolved: #44699

Changelog: [Internal]

In Fabric, overflow props for ScrollView is not passed down. Hence, the overflow props is ignored and FlatList content is always clipped.

Reported from OSS #44683

Reviewed By: sammy-SC

Differential Revision: D57895399

fbshipit-source-id: 6ce65bea0803971060e8229b66563123dd6fc114
Titozzz pushed a commit that referenced this issue Jun 18, 2024
Summary:
Pull Request resolved: #44699

Changelog: [Internal]

In Fabric, overflow props for ScrollView is not passed down. Hence, the overflow props is ignored and FlatList content is always clipped.

Reported from OSS #44683

Reviewed By: sammy-SC

Differential Revision: D57895399

fbshipit-source-id: 6ce65bea0803971060e8229b66563123dd6fc114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: FlatList Needs: Triage 🔍 Platform: iOS iOS applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

No branches or pull requests

3 participants