Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS RN:0.14.2 Border Radius - Blur #4604

Closed
export-mike opened this issue Dec 6, 2015 · 8 comments
Closed

iOS RN:0.14.2 Border Radius - Blur #4604

export-mike opened this issue Dec 6, 2015 · 8 comments
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@export-mike
Copy link

Hi, I've found the borders to blur on iOS when setting border radius on less than four corners...

https://rnplay.org/apps/mGNsBQ
image

RN version:0.14.2

I originally had commented on this issue: #3040 (comment) but realised the issue is related to Android.
@facebook-github-bot
Copy link
Contributor

Hey mikeljames, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If this is a feature request or a bug that you would like to be fixed by the team, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • If you don't know how to do something or not sure whether some behavior is expected or a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • We welcome clear issues and PRs that are ready for in-depth discussion; thank you for your contributions!

@skevy skevy added the Platform: iOS iOS applications. label Dec 7, 2015
@rjoonas
Copy link

rjoonas commented Dec 11, 2015

More examples at #2089

@weicool
Copy link
Contributor

weicool commented Jan 5, 2016

I'm also seeing this:

pill_border_radius

nicklockwood added a commit that referenced this issue Jan 7, 2016
@nicklockwood
Fixed border smearing issue
b115277 
Summary:
public
The iOS border rendering code did not follow the CSS spec in cases where the sum of adjacent border radii was greater than the width of the view, resulting in drawing glitches such as pixel smear and borders appearing stretched or squashed.

This diff brings our implementation closer to spec-compliance in these cases. I also fixed a longstanding issue with ghostly diagonal lines appearing at the corners due to antialiasing rounding errors!

Fixes

#1572
#2089
#4604

Reviewed By: tadeuzagallo

Differential Revision: D2811249

fb-gh-sync-id: c3dd2721e0a01a432fa4dc78daa05680595edd08
@brentvatne
Copy link
Collaborator

Fixed in b115277

christopherdro pushed a commit to wildlifela/react-native that referenced this issue Jan 20, 2016
@nicklockwood @christopherdro
Fixed border smearing issue
d5a0b08 
Summary:
public
The iOS border rendering code did not follow the CSS spec in cases where the sum of adjacent border radii was greater than the width of the view, resulting in drawing glitches such as pixel smear and borders appearing stretched or squashed.

This diff brings our implementation closer to spec-compliance in these cases. I also fixed a longstanding issue with ghostly diagonal lines appearing at the corners due to antialiasing rounding errors!

Fixes

facebook#1572
facebook#2089
facebook#4604

Reviewed By: tadeuzagallo

Differential Revision: D2811249

fb-gh-sync-id: c3dd2721e0a01a432fa4dc78daa05680595edd08
@worldlyjohn
Copy link

what version of RN did this make it into? i'm still affected by this issue running:

  • "react": "15.3.1",
  • "react-native": "0.33.0",

@lerman
Copy link

lerman commented Oct 7, 2016

I'm also seeing this issue still

@rneiss
Copy link

rneiss commented Oct 27, 2016

Still seeing on 0.35.0:
untitled

@bedemiralp bedemiralp mentioned this issue Apr 1, 2017
Closed
@selvabics
Copy link

add this style, overflow: 'hidden'

@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests