React packager failing - SyntaxError: Unexpected end of input

[ColinEberhardt]

Unfortunately I am having issues with getting the movies example app working :-(

I have installed watchman as per the instructions, and already had node v0.10.36 installed.

On running npm start all seems well. However when I load the movies example it fails.

Testing via the URL:

http://localhost:8081/Examples/Movies/MoviesApp.includeRequire.runModule.bundle

Yields the following error:

{"type":"InternalError","message":"React packager has encountered an internal error, please check your terminal error output for more details"}

And here is the terminal output:

$ npm start

> react-native@0.0.1 start /Users/colineberhardt/Projects/react-native
> ./packager/packager.sh


 ===============================================================
 |  Running packager on port 8081.       
 |  Keep this packager running while developing on any JS         
 |  projects. Feel free to close this tab and run your own      
 |  packager instance if you prefer.                              
 |                                                              
 |     https://github.com/facebook/react-native                 
 |                                                              
 ===============================================================


React packager ready.

SyntaxError: Unexpected end of input
    at Object.parse (native)
    at /Users/colineberhardt/Projects/react-native/packager/react-packager/src/DependencyResolver/haste/DependencyGraph/index.js:270:32
    at _fulfilled (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:749:13)
    at /Users/colineberhardt/Projects/react-native/node_modules/q/q.js:557:44
    at flush (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:108:17)
    at process._tickCallback (node.js:442:13)
[17:52:41] <START> find dependencies

I've had a poke around DependencyGraph and tried to add some logging but haven't made much progress.

Has anyone else ecountered (and maybe solved!) this issue?

[vjeux]

cc @amasad

[jimjeffers]

I'm running into the same issue here. Here are my local node and npm versions just for reference:

→ npm -v
2.1.7

→ node -v
v0.10.33

[amasad]

That failure is at a line where it's trying to JSON.parse a package.json file. I'm looking into this now but do you have any custom node module that may have a malformed package.json?

[amasad]

Hey @jimjeffers @ColinEberhardt can you add a console.log(content) before this line https://github.com/facebook/react-native/blob/master/packager/react-packager/src/DependencyResolver/haste/DependencyGraph/index.js#L270
That way we know what is failing to parse.

[ColinEberhardt]

Thanks @amasad - this is the strange thing, when I add a console.log ...

      .then(function(content) {
        console.log(content);
        var packageJson = JSON.parse(content);

I observe the following:

--- snip lots of package.json output above ---
{
    "main" : "./lib"
}

SyntaxError: Unexpected end of input
    at Object.parse (native)
    at /Users/colineberhardt/Projects/react-native/packager/react-packager/src/DependencyResolver/haste/DependencyGraph/index.js:271:32
    at _fulfilled (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:749:13)
    at /Users/colineberhardt/Projects/react-native/node_modules/q/q.js:557:44
    at flush (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:108:17)
    at process._tickCallback (node.js:442:13)
[20:29:18] <START> find dependencies

i.e. it outputs lots of package.json output, all of which looks fine. Then it hits the error but I don't see content in the console log.

I've added logging to try and determine which file is causing issues:

    if (packagePath != null) {
      console.log('opening package: ' + packagePath);
      return readFile(packagePath, 'utf8')
        .then(function(content) {
          console.log('opened package: ' + packagePath);
          var packageJson = JSON.parse(content);

On npm start I see a whole lot of logging, ending as follows:

opening package: /Users/colineberhardt/Projects/react-native/node_modules/react-tools/node_modules/commoner/node_modules/recast/node_modules/source-map/node_modules/amdefine/package.json
opened package: /Users/colineberhardt/Projects/react-native/node_modules/react-tools/node_modules/commoner/node_modules/recast/node_modules/source-map/node_modules/amdefine/package.json
opening package: /Users/colineberhardt/Projects/react-native/node_modules/module-deps/node_modules/browser-resolve/node_modules/resolve/test/resolver/biz/node_modules/garply/package.json
opened package: /Users/colineberhardt/Projects/react-native/node_modules/module-deps/node_modules/browser-resolve/node_modules/resolve/test/resolver/biz/node_modules/garply/package.json

Then as soon as I hit the URL in the browser, the following error is logged:

SyntaxError: Unexpected end of input
    at Object.parse (native)
    at /Users/colineberhardt/Projects/react-native/packager/react-packager/src/DependencyResolver/haste/DependencyGraph/index.js:272:32
    at _fulfilled (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:749:13)
    at /Users/colineberhardt/Projects/react-native/node_modules/q/q.js:557:44
    at flush (/Users/colineberhardt/Projects/react-native/node_modules/q/q.js:108:17)
    at process._tickCallback (node.js:442:13)
[20:34:18] <START> find dependencies

I'm a bit baffled as i would have expected some logging before the error to indicate which package.json it was opening.

Confused!

[vjeux]

@amasad would be nice to add a proper error message if a package.json file is malformed

[amasad]

It seems like it's choking on some test package.json files. I think we should ignore malformed package.json and just warn when building the dependency graph. Once the user require that module will figure out that something is wrong.

[amasad]

@ColinEberhardt will land a fix soon but try this for now:

-        var packageJson = JSON.parse(content);
-        if (packageJson.name == null) {
+        var packageJson;
+        try {
+          packageJson = JSON.parse(content);
+        } catch (e) {
+          debug('WARNING: malformed package.json: ', packagePath);
+          return q();
+        }

[ColinEberhardt]

Thanks @amasad - here's the culprit:

WARNING: malformed package.json:  /Users/colineberhardt/Projects/react-native/node_modules/npm/test/fixtures/config/package.json

[amasad]

Interesting, why do you have npm in mode_modules? Do we require it as a
dependency?

Regardless, will land the fix to ignore these malformed packages.

On Saturday, February 7, 2015, Colin Eberhardt notifications@github.com
wrote:

Thanks @amasad https://github.com/amasad - here's the culprit:

WARNING: malformed package.json: /Users/colineberhardt/Projects/react-native/node_modules/npm/test/fixtures/config/package.json

—
Reply to this email directly or view it on GitHub
#47 (comment)
.

[ColinEberhardt]

Ahhhh!!! Found the issue - I mistakenly cut and paste the instructions from the README:

npm install npm start

Note, the lack of line-break, which causes an npm install npm. Must have just been running on auto-pilot!

[amasad]

Haha no worries at all. Thanks for exposing this bug

On Saturday, February 7, 2015, Colin Eberhardt notifications@github.com
wrote:

Ahhhh!!! Found the issue - I mistakenly cut and paste the instructions
from the README:

npm install npm start

Note, the lack of line-break, which causes an npm install npm. Must have
just been running on auto-pilot!

—
Reply to this email directly or view it on GitHub
#47 (comment)
.

[vjeux]

We fixed both the README and the error message. Thanks for this!