Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.20] Commits to cherry pick #5762

Closed
18 of 20 tasks
bestander opened this issue Feb 4, 2016 · 18 comments
Closed
18 of 20 tasks

[release-0.20] Commits to cherry pick #5762

bestander opened this issue Feb 4, 2016 · 18 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@bestander
Copy link
Contributor

@oviava
Copy link

oviava commented Feb 5, 2016

Would be nice to get this going facebook/relay@60c8a76 along with the dependencies #5084 & #4062


will be in master KR

@ide
Copy link
Contributor

ide commented Feb 5, 2016

@oviava we'll probably ship that with 0.21 or 0.22 since those PRs aren't bug fixes and also haven't been reviewed. The primary intent of the period between RC and release is to improve stability.

@oviava
Copy link

oviava commented Feb 5, 2016

oups .. hadn't realized 20rc had been released

@mkonicek
Copy link
Contributor

mkonicek commented Feb 5, 2016

Regarding #5717: maybe I was too quick to enable Proguard for everyone and we should disable it until we have an automated test on CircleCI: https://github.com/facebook/react-native/blob/master/local-cli/generator-android/templates/src/app/build.gradle#L76

Proguard can shave off about 1MB from the APK size.

@bestander
Copy link
Contributor Author

@mkonicek regarding proguard, do you want me to create a PR and cherry pick it too?

@bestander
Copy link
Contributor Author

Ok, created #5775

@janicduplessis
Copy link
Contributor

#5784 fix issue that breaks scroll views w/ RefreshControl on Android


in the list

@daesan
Copy link
Contributor

daesan commented Feb 6, 2016

Any reason 0.20.0-rc is not published to npm?

@bestander
Copy link
Contributor Author

Will be published once we have release notes.
Hopefully today

On Saturday, 6 February 2016, Dae San Hwang notifications@github.com
wrote:

Any reason 0.20.0-rc is not published to npm?


Reply to this email directly or view it on GitHub
#5762 (comment)
.

@skevy
Copy link
Contributor

skevy commented Feb 10, 2016

c9a1956

Fixes RCTPromise, and should make it into stable.


in the list

@skevy
Copy link
Contributor

skevy commented Feb 10, 2016

fix issue that breaks scroll views w/ RefreshControl on Android 9879717


in the list

@bestander
Copy link
Contributor Author

@andreicoman11 is the display metrics bug fix ready?
Do we want to cherry-pick it into the release that is coming on Monday?

@bestander
Copy link
Contributor Author

Not picking this PR: [Navigator][0.19.0][ios][bug]: Scene Component will render twice and more #5726

@andreicoman11
Copy link
Contributor

Yep, should be good to go 228a1fe


added to list

@bestander
Copy link
Contributor Author

To all interested parties: I cherry-picked all the fixes and now ready to do a release.
The 2 issues don't have commits cherry-picked because they are not resolved.

@bestander
Copy link
Contributor Author

Closing, release in progress

@shaikhussian
Copy link

I am getting an error in RCTwebSocket.m expression result unused using react-native version-0.20.0

@bestander
Copy link
Contributor Author

@shaikhussian, we have already moved on to 0.21.0, it is considered stable.
Do you have any problem updating to it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests