-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.20] Commits to cherry pick #5762
Comments
Would be nice to get this going facebook/relay@60c8a76 along with the dependencies #5084 & #4062 will be in master KR |
@oviava we'll probably ship that with 0.21 or 0.22 since those PRs aren't bug fixes and also haven't been reviewed. The primary intent of the period between RC and release is to improve stability. |
oups .. hadn't realized 20rc had been released |
Regarding #5717: maybe I was too quick to enable Proguard for everyone and we should disable it until we have an automated test on CircleCI: https://github.com/facebook/react-native/blob/master/local-cli/generator-android/templates/src/app/build.gradle#L76 Proguard can shave off about 1MB from the APK size. |
@mkonicek regarding proguard, do you want me to create a PR and cherry pick it too? |
Ok, created #5775 |
#5784 fix issue that breaks scroll views w/ RefreshControl on Android in the list |
Any reason 0.20.0-rc is not published to npm? |
Will be published once we have release notes. On Saturday, 6 February 2016, Dae San Hwang notifications@github.com
|
Fixes RCTPromise, and should make it into stable. in the list |
fix issue that breaks scroll views w/ RefreshControl on Android 9879717 in the list |
@andreicoman11 is the display metrics bug fix ready? |
Not picking this PR: [Navigator][0.19.0][ios][bug]: Scene Component will render twice and more #5726 |
Yep, should be good to go 228a1fe added to list |
To all interested parties: I cherry-picked all the fixes and now ready to do a release. |
Closing, release in progress |
I am getting an error in RCTwebSocket.m expression result unused using react-native version-0.20.0 |
@shaikhussian, we have already moved on to 0.21.0, it is considered stable. |
getDisplayMetrics
as to not overwrite Android global state #5764 commitgetRealMetrics
for display metrics. Closes Dimensions.get('window').height is sometimes wrong on Android #4934 8e60394getDisplayMetrics
as to not overw 1ef0b8fThe text was updated successfully, but these errors were encountered: