Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.32.1] Commits to cherry pick into stable release #9431

Closed
grabbou opened this issue Aug 16, 2016 · 21 comments
Closed

[0.32.1] Commits to cherry pick into stable release #9431

grabbou opened this issue Aug 16, 2016 · 21 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@grabbou
Copy link
Contributor

grabbou commented Aug 16, 2016

No description provided.

@satya164
Copy link
Contributor

FYI we've bunch of regressions in latest release - https://github.com/facebook/react-native/issues?q=is%3Aissue+is%3Aopen+label%3ARegression

bestander referenced this issue Aug 16, 2016
@hramos
Update Edit on GitHub links to point to master
cadc727 
Summary:
We've been getting a lot of documentation PRs opened against `0.29-stable`, `0.30-stable`, and so on, instead of `master`. This is because our doc site is also based on RN release cuts, so clicking on the "Edit on GitHub" links on a document will take you to the markdown source for that release branch instead of the latest doc on `master`.

See #9095 for an example of such a PR.

In this PR we edit the link to say View on GitHub. Though it may not prevent PRs from being opened against a release branch, removing the "Edit" CTA may help in this regard.
Closes #9149

Differential Revision: D3664368

Pulled By: vjeux

fbshipit-source-id: 395c0813f736bfbe1be4b4fb1182f9060169365d
@sjmueller
Copy link
Contributor

I haven't seen it mentioned yet, but I'm noticing big problems with image loading and caching in 0.32. In fact it seems like images are not cached at all, resulting in super slow image load times (especially for repeated images like avatars). It prompted me to look through the commit history, and the large image cache refactor could be the culprit: ddc70ff

Should I create a separate issue or is there already something out there covering it?

@bestander
Copy link
Contributor

@sjmueller, please raise a separate issue with a video example if you can and cc people related to the change.
Also cc me, I'll link it internally.

@grabbou
Copy link
Contributor Author

grabbou commented Aug 21, 2016

Nothing explicitly listed so will release w/o cherry-picks.

@grabbou grabbou closed this as completed Aug 21, 2016
@bestander
Copy link
Contributor

@grabbou, we want to investigate the image caching issue internally a bit.
Can we delay stable forma day or two?

@satya164 satya164 reopened this Aug 21, 2016
@grabbou
Copy link
Contributor Author

grabbou commented Aug 21, 2016

It's not yet deployed so it's up to you. Just let me know so I'll update interested ppl via twitter :)

@sjmueller
Copy link
Contributor

Hey all, apologies for the delay regarding image cache / decoding issues. Would you still like me to submit an issue, or did your internal investigation yield the same findings?

@bestander
Copy link
Contributor

Yes Sam, please submit one.
Also if you could help investigating it would be much appreciated

On Tuesday, 23 August 2016, Sam Mueller notifications@github.com wrote:

Hey all, apologies for the delay regarding image cache / decoding issues.
Would you still like me to submit an issue, or did your internal
investigation yield the same findings?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#9431 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBdWOmCUzW96uiyufHiW4W25zb8sJ_0ks5qiqajgaJpZM4JlRQa
.

@nihgwu
Copy link
Contributor

nihgwu commented Aug 23, 2016

@sjmueller I've noticed that issue too, when i preview the loaded image, the image is loaded again, seems the cache doesn't work, I'm using RN0.32RC0

@nihgwu nihgwu mentioned this issue Aug 24, 2016
Closed
@satya164
Copy link
Contributor

Let's cherry-pick b4999fc

@mkonicek
Copy link
Contributor

Let's cherry-pick b4999fc

Yes please. This is the fix for Chrome debugger by @lexs, awesome!

@javache
Copy link
Member

javache commented Aug 24, 2016

Could someone provide some repro instructions for the caching issue? Does this happen on iOS or Android? What are example image URLs that are not cached?

@grabbou
Copy link
Contributor Author

grabbou commented Aug 24, 2016 •
edited
Loading

Also bring back android command commit should be cherry-picked before we ship tomorrow morning.

@javache @bestander @sjmueller shall we move to a separate issue so the cherry-pick thread is not polluted with unrelated comments?

@mkonicek
Copy link
Contributor

mkonicek commented Aug 24, 2016 •
edited
Loading

shall we move to a separate issue

Yes, is there an issue for the image caching? If not just create one :) ddc70ff looks like it might be related, good find @sjmueller! And yeah, we need a repro :) Have more people seen images never being cached? This is only on iOS, correct?

@bestander
Copy link
Contributor

Yes, we should definitely

On Wednesday, 24 August 2016, Mike Grabowski notifications@github.com
wrote:

Also bring back android command from rnpm - in the morning.

@javache https://github.com/javache @bestander
https://github.com/bestander @sjmueller https://github.com/sjmueller
shall we move to a separate issue so the cherry-pick thread is not polluted
with unrelated comments?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9431 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBdWK_Z-Z0dl9wPchY06lh4rmoFkZjbks5qjH7KgaJpZM4JlRQa
.

@rclai
Copy link
Contributor

rclai commented Aug 25, 2016 •
edited
Loading

Question: is this note still in effect (video loading via asset system on iOS)?

@sjmueller sjmueller mentioned this issue Aug 25, 2016
Closed
@alloy
Copy link
Contributor

alloy commented Aug 25, 2016 •
edited
Loading

If this fix for building a framework version of React Native (with e.g. CocoaPods) gets merged before the release, I’d love to see that go in.

@bestander
Copy link
Contributor

To pick into 0.32.1

@grabbou
Copy link
Contributor Author

grabbou commented Aug 25, 2016

@alloy looks like it's not yet merged, but I'll do as a 0.32.1 as @bestander suggested.

@grabbou grabbou changed the title [0.32] Commits to cherry pick into stable release [0.32.1] Commits to cherry pick into stable release Aug 25, 2016
@MajeedThaikas
Copy link

I concor

@alloy
Copy link
Contributor

alloy commented Sep 19, 2016

@grabbou This can be closed.

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests