Add an integration test for WebSocket #11433
Conversation
|
By analyzing the blame information on this pull request, we identified @fkgozali and @bestander to be potential reviewers. |
|
@satya164 Here's a network test that will hopefully run in Travis CI, per our discussion in Slack. Please take a look and see what you think. |
facebook-github-bot
added
the
CLA Signed
| var connectSucceeded = true; | ||
| var component = this; | ||
| component._connect(); | ||
| component._waitFor(component._socketIsConnected,5,function(result) { |
There was a problem hiding this comment.
number This type is incompatible with the expected param type of Number
| ]; | ||
|
|
||
| class WebSocketTest extends React.Component { | ||
| state: State = { |
There was a problem hiding this comment.
identifier State Could not resolve name
| callback(true); | ||
| return; | ||
| } | ||
| remaining--; |
There was a problem hiding this comment.
Number The operand of an arithmetic operation must be a number.
| } | ||
| var disconnectSucceeded = true; | ||
| component._disconnect(); | ||
| component._waitFor(component._socketIsDisconnected,5,function(result2) { |
There was a problem hiding this comment.
number This type is incompatible with the expected param type of Number
|
@facebook-github-bot shipit |
1 similar comment
|
@facebook-github-bot shipit |
|
@facebook-github-bot shipit |
facebook-github-bot
added
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
removed
the
Import Started
facebook-github-bot
added
the
Import Started
|
Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this. |
facebook-github-bot
removed
the
Import Started
facebook-github-bot
added
the
Import Started
|
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
removed
the
Import Started
facebook-github-bot
added
the
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: **Motivation** See if we can safely run a WebSocket test in Travis CI Closes facebook#11433 Differential Revision: D4342024 Pulled By: ericvicenti fbshipit-source-id: 137fb0c39ed7ea3726e2778d5c0bdac4cef6ab89
Summary: **Motivation** See if we can safely run a WebSocket test in Travis CI Closes facebook/react-native#11433 Differential Revision: D4342024 Pulled By: ericvicenti fbshipit-source-id: 137fb0c39ed7ea3726e2778d5c0bdac4cef6ab89
Motivation
See if we can safely run a WebSocket test in Travis CI