Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RecyclerViewBackedScrollView #11445

Closed
wants to merge 1 commit into from
Closed

Deprecate RecyclerViewBackedScrollView #11445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Libraries/Components/ScrollView/RecyclerViewBackedScrollView.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@ var requireNativeComponent = require('requireNativeComponent');
var INNERVIEW = 'InnerView';

/**
* Wrapper around android native recycler view.
* RecyclerViewBackedScrollView is DEPRECATED and will be removed from
* React Native.
* Please use a `ListView` which has `removeClippedSubviews` enabled by
* default so that rows that are out of sight are automatically
* detached from the view hierarchy.
*
* Wrapper around Android native recycler view.
*
* It simply renders rows passed as children in a separate recycler view cells
* similarly to how `ScrollView` is doing it. Thanks to the fact that it uses
Expand Down Expand Up @@ -58,6 +64,13 @@ var RecyclerViewBackedScrollView = React.createClass({

mixins: [ScrollResponder.Mixin],

componentWillMount: function() {
console.warn(
'RecyclerViewBackedScrollView is DEPRECATED and will be removed from React Native. ' +
'Please use a ListView which has removeClippedSubviews enabled by default so that ' +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semi: Missing semicolon.

'rows that are out of sight are automatically detached from the view hierarchy.')
},

getInitialState: function() {
return this.scrollResponderMixinGetInitialState();
},
Expand Down