Remove deprecated RecyclerViewBackedScrollView #11519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
tychota
force-pushed
the
remove/recycler-view-scrollview
branch
from
f3d66e1 to
d7285e9
Compare
eslint-bot
reviewed
Dec 17, 2016
| @@ -63,8 +62,7 @@ var ListViewSimpleExample = React.createClass({ | |||
| noScroll={true}> | |||
| <ListView | |||
| dataSource={this.state.dataSource} | |||
| renderRow={this._renderRow} | |||
| renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />} | |||
eslint-bot
reviewed
Dec 17, 2016
| @@ -63,8 +62,7 @@ var ListViewSimpleExample = React.createClass({ | |||
| noScroll={true}> | |||
| <ListView | |||
| dataSource={this.state.dataSource} | |||
| renderRow={this._renderRow} | |||
| renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />} | |||
There was a problem hiding this comment.
identifier props Could not resolve name
tychota
force-pushed
the
remove/recycler-view-scrollview
branch
from
d7285e9 to
b3845fd
Compare
|
@mkonicek : what do you think about this PR ? If you are interested, please let me know so I can rebase. Let me know how I can help otherwise :) |
tychota
force-pushed
the
remove/recycler-view-scrollview
branch
from
b3845fd to
15ab622
Compare
tychota
force-pushed
the
remove/recycler-view-scrollview
branch
from
15ab622 to
698a9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow pull request #11445
The RecyclerViewBackedScrollView:
cc @brentvatne @mkonicek @lacker
cc @grabbou
Test plan (required)
Apart running the test on CI, is there other things I should test ??
Code formatting
I haven't added code in this PR, it is just massive deletion.