Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IntegrationWithExistingApps.md #12475

Closed
wants to merge 4 commits into from

Conversation

Brian-Kaplan
Copy link

@Brian-Kaplan Brian-Kaplan commented Feb 20, 2017

Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@Brian-Kaplan
Copy link
Author

@lacker your wish is my command

@hramos
Copy link
Contributor

hramos commented Feb 20, 2017

Thanks for sending this pull request! We would love to review your changes however it looks like you haven't signed the CLA yet. You can do so at https://code.facebook.com/cla.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Brian-Kaplan
Copy link
Author

@hramos @lacker why are your CI tests failing because of this?

@lacker
Copy link
Contributor

lacker commented Feb 21, 2017

Seems unrelated. Let me try rerunning them.

@hramos
Copy link
Contributor

hramos commented Feb 21, 2017

CI failures are likely to be unrelated. We're currently working on getting the tests back to green.

@Brian-Kaplan
Copy link
Author

@hramos @lacker any updates on these tests?

@hramos
Copy link
Contributor

hramos commented Feb 23, 2017

@Brian-Kaplan we're still working on it.

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Feb 23, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

GaborWnuk pushed a commit to GaborWnuk/react-native that referenced this pull request Feb 28, 2017
Summary:
Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others.
Closes facebook#12475

Differential Revision: D4608443

Pulled By: hramos

fbshipit-source-id: eb719d5cf9d905c4f043ec71f1a3e28e0219626e
dudeinthemirror pushed a commit to dudeinthemirror/react-native that referenced this pull request Mar 1, 2017
Summary:
Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others.
Closes facebook#12475

Differential Revision: D4608443

Pulled By: hramos

fbshipit-source-id: eb719d5cf9d905c4f043ec71f1a3e28e0219626e
dudeinthemirror pushed a commit to dudeinthemirror/react-native that referenced this pull request Mar 1, 2017
Summary:
Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others.
Closes facebook#12475

Differential Revision: D4608443

Pulled By: hramos

fbshipit-source-id: eb719d5cf9d905c4f043ec71f1a3e28e0219626e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants