-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IntegrationWithExistingApps.md #12475
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
@lacker your wish is my command |
Thanks for sending this pull request! We would love to review your changes however it looks like you haven't signed the CLA yet. You can do so at https://code.facebook.com/cla. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Seems unrelated. Let me try rerunning them. |
CI failures are likely to be unrelated. We're currently working on getting the tests back to green. |
@Brian-Kaplan we're still working on it. |
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others. Closes facebook#12475 Differential Revision: D4608443 Pulled By: hramos fbshipit-source-id: eb719d5cf9d905c4f043ec71f1a3e28e0219626e
Summary: Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others. Closes facebook#12475 Differential Revision: D4608443 Pulled By: hramos fbshipit-source-id: eb719d5cf9d905c4f043ec71f1a3e28e0219626e
Summary: Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others. Closes facebook#12475 Differential Revision: D4608443 Pulled By: hramos fbshipit-source-id: eb719d5cf9d905c4f043ec71f1a3e28e0219626e
Just a little nit pick to add extra information to this doc. I spent a few hours trying to fix this problem because I had not placed the code in build.gradle correctly. I think this small addition would be useful to others.