Include syntax-class-properties in packager #12550
Conversation
This includes the babel-plugin-syntax-class-properties in packager/babelRegisterOnly.js Babylon 6.16.0 fix a problem that we were parsing class properties allthough the plugin was not enabled. This change fails in react-native as class-proeprties are use in node-haste, but the plugin is not enabled in react-native.
facebook-github-bot
added
CLA Signed
|
Thanks for the PR! BTW the React Native codebase has two parts - the code that you run on a phone and the code for the server that runs on your computer. @facebook-github-bot shipit |
|
@ide has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Actually, I realized the bot might have some trouble merging this commit because it adds a new package.json dependency. @hramos do you think you could help merge this? |
|
Sure thing |
|
Hi there! The packager no longer lives in this repo. It now lives in https://github.com/facebook/metro-bundler. The reasoning for the split is explained here: #13976. If you're still interested in pursuing this PR, please open the PR on that repo! :) Thanks! |
Babylon 6.16.0 fixed a problem that it was parsing class properties although the corresponding plugin was not enabled. This leas to react-native breaking with the new version of babylon as class-properties are use in node-haste, but the plugin is not enabled in react-native.
We for the time being reverted some changes and released 6.16.1, but going to reenable them at some point.
I'm not 100% sure if it is the correct package.json file I changed, let me know if not. It would also be included due to
babel-preset-react-native, but maybe better be explicit.Fixes #12542 and #12545 if released as bugfix release for the latest version.