-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more documentation in ListViewDataSource #1285
Conversation
ListViewDataSource's default data extractor can actually expect another data form: `{ sectionID_1: [ <rowData1>, <rowData2>, ... ], ... }`
@facebook-github-bot import |
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1593093057609165/int_phab to review. |
Thanks for the fix! In the future, please make sure to clean up trailing spaces and any other lint. |
Sorry, I just added something in the comment. Why do we need to clean up trailing spaces and any other lint in this context? |
code is code and lint is lint, whether it's a comment or not. |
OK. I just noticed that there are trailing spaces. I didn't mean it and it's hard to find. Sorry. |
Some editors can be configured to automatically remove trailing whitespace which is nice. Does running lint pick up these issues for you?
|
Oh, I edited the file using GitHub's edit button because I think the change is minor... (My IDE, WebStorm, for my react native project has the automatic trailing space removal feature.) I'm new to node.js and |
Thank you @sahrens! Just saw the update of CONTRIBUTING.md |
* Update animations.md. A small typo fix. * Update animations.md
ListViewDataSource's default data extractor can actually expect another data form:
{ sectionID_1: [ <rowData1>, <rowData2>, ... ], ... }