Update Keyboard.js #13155
Update Keyboard.js #13155
Conversation
According to this issue: facebook#3468 , only `keyboardDidShow`and `keyboardDidHide` events are available on android. I think this information should be displayed in the documentation since default `android:windowSoftInputMode` is `adjustResize`.
facebook-github-bot
added
CLA Signed
| @@ -98,7 +98,10 @@ let Keyboard = { | |||
| * - `keyboardDidHide` | |||
| * - `keyboardWillChangeFrame` | |||
| * - `keyboardDidChangeFrame` | |||
| * | |||
| * | |||
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
| * | ||
| * Note that if you set `android:windowSoftInputMode` to `adjustResize` or `adjustNothing`, | ||
| * only `keyboardDidShow` and `keyboardDidHide` events will available on android. | ||
| * |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: What existing problem does the pull request solve? According to this issue: facebook#3468 , only `keyboardDidShow`and `keyboardDidHide` events are available on android at this moment. I think this information should be displayed in the documentation since default `android:windowSoftInputMode` is `adjustResize`. Closes facebook#13155 Differential Revision: D4795828 Pulled By: hramos fbshipit-source-id: 2c114f3040808a5cc3cdeb29b2067877df353620
Motivation (required)
What existing problem does the pull request solve?
According to this issue: #3468 , only
keyboardDidShowandkeyboardDidHideevents are available on android at this moment.I think this information should be displayed in the documentation since default
android:windowSoftInputModeisadjustResize.