New heading clarifies the usage of AppRegistry #13601
Conversation
I made the fatal mistake of including a call to AppRegistry for every component I was exporting because I didn't know how it worked. This introduced very strange bugs which I would've never fixed it I hadn't asked for help. The main reason for my mistake is that the usage of AppRegistry was not sufficiently explained in the docs. So here's to fixing that!
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@dikaiosune Ok that's fine. In that case I think it should be placed wherever AppRegistry is first introduced. Perhaps in the API menu, where the explanation could still use some work. |
|
It looks like this PR doesn't change much. The text already explains that this is to only be called once for the whole app. |
|
@barvin I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
I made the fatal mistake of including a call to AppRegistry for every component I was exporting because I didn't know how it worked.
This introduced very strange bugs which I would've never fixed it I hadn't asked for help.
The main reason for my mistake is that the usage of AppRegistry was not sufficiently explained in the docs.
So here's to fixing that!