Android: Make lineHeight accept decimal values #13843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make android-version accept a decimal number as lineHeight. According to the spec the property line-height should accept decimal values (and it does on iOS) but the android version has the wrong data-type for the shadowed method, resulting in a stacktrace saying: com.facebook.react.bridge.UnexpectedNativeTypeException: TypeError: expected dynamic type `int64', but had type `double' Setting it to a float makes it accept decmial values as it should. Credits where due, solution was given in this issue: facebook#10607 Verification: * Create an app without this fix: * Create the same app with this fix: - Leave line-height undefined. Behaviour is same as before. - Set lineHeight to a integer number: Behaviour is same as before. - Set lineHeight to a decimal number. Line height is now rendered with decimals. * Run android integration tests to see nothing else broke.
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make android-version accept a decimal
number as lineHeight.
Credits where due, solution was given in this
issue: #10607
Motivation (required)
According to the w3 spec the property
line-height should accept decimal values
(and it does on iOS) but the android
version has the wrong data-type for the
shadowed method, resulting in a stacktrace
saying:
com.facebook.react.bridge.UnexpectedNativeTypeException: TypeError:
expected dynamic type
int64', but had typedouble'Setting it to a float makes it accept
decmial values as it should.
Test Plan (required)
In both apps:
else broke.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.