[RCTScrollView] Make ScrollView detect taps on sticky headers #1415
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
brentvatne
changed the title
|
@ide - good call, changed |
tadeuzagallo
pushed a commit
to tadeuzagallo/react-native
that referenced
this pull request
May 28, 2015
Summary: As per discussion with @nicklockwood in facebook#875, make `RCTScrollView` check its sticky headers for hitTests first. Closes facebook#1415 Github Author: Brent Vatne <brent.vatne@madriska.com> Test Plan: Have a sticky header in a ScrollView with a Touchable onPress action, scroll a bit after it docks and try tapping, should respond to tap.
|
Hey @shayne - noticed that you just closed this again, did this turn out to not be a problem after all? |
|
Working with Christopher on how we want to collect regressions. Since the On Mon, Jun 1, 2015 at 12:13 PM, Brent Vatne notifications@github.com
|
|
@shayne - ah ok, thanks! |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion with @nicklockwood in #875, make
RCTScrollViewcheck its sticky headers for hitTests first.Test Plan: Have a sticky header in a ScrollView with a Touchable onPress action, scroll a bit after it docks and try tapping, should respond to tap.