-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Update Image.getSize to use encoded image #14358
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,8 @@ | |
import com.facebook.datasource.DataSubscriber; | ||
import com.facebook.drawee.backends.pipeline.Fresco; | ||
import com.facebook.imagepipeline.core.ImagePipeline; | ||
import com.facebook.imagepipeline.image.CloseableImage; | ||
import com.facebook.imagepipeline.image.EncodedImage; | ||
import com.facebook.imagepipeline.memory.PooledByteBuffer; | ||
import com.facebook.imagepipeline.request.ImageRequest; | ||
import com.facebook.imagepipeline.request.ImageRequestBuilder; | ||
import com.facebook.react.bridge.Arguments; | ||
|
@@ -81,22 +82,23 @@ public void getSize( | |
Uri uri = Uri.parse(uriString); | ||
ImageRequest request = ImageRequestBuilder.newBuilderWithSource(uri).build(); | ||
|
||
DataSource<CloseableReference<CloseableImage>> dataSource = | ||
Fresco.getImagePipeline().fetchDecodedImage(request, mCallerContext); | ||
DataSource<CloseableReference<PooledByteBuffer>> dataSource = | ||
Fresco.getImagePipeline().fetchEncodedImage(request, mCallerContext); | ||
|
||
DataSubscriber<CloseableReference<CloseableImage>> dataSubscriber = | ||
new BaseDataSubscriber<CloseableReference<CloseableImage>>() { | ||
DataSubscriber<CloseableReference<PooledByteBuffer>> dataSubscriber = | ||
new BaseDataSubscriber<CloseableReference<PooledByteBuffer>>() { | ||
@Override | ||
protected void onNewResultImpl( | ||
DataSource<CloseableReference<CloseableImage>> dataSource) { | ||
DataSource<CloseableReference<PooledByteBuffer>> dataSource) { | ||
if (!dataSource.isFinished()) { | ||
return; | ||
} | ||
CloseableReference<CloseableImage> ref = dataSource.getResult(); | ||
CloseableReference<PooledByteBuffer> ref = dataSource.getResult(); | ||
if (ref != null) { | ||
EncodedImage image = ref.get(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, how come this doesn't warn about trying to assign a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right it's my bad |
||
try { | ||
CloseableImage image = ref.get(); | ||
|
||
image.parseMetaData(); | ||
WritableMap sizes = Arguments.createMap(); | ||
sizes.putInt("width", image.getWidth()); | ||
sizes.putInt("height", image.getHeight()); | ||
|
@@ -106,14 +108,15 @@ protected void onNewResultImpl( | |
promise.reject(ERROR_GET_SIZE_FAILURE, e); | ||
} finally { | ||
CloseableReference.closeSafely(ref); | ||
image.close(); | ||
} | ||
} else { | ||
promise.reject(ERROR_GET_SIZE_FAILURE); | ||
} | ||
} | ||
|
||
@Override | ||
protected void onFailureImpl(DataSource<CloseableReference<CloseableImage>> dataSource) { | ||
protected void onFailureImpl(DataSource<CloseableReference<PooledByteBuffer>> dataSource) { | ||
promise.reject(ERROR_GET_SIZE_FAILURE, dataSource.getFailureCause()); | ||
} | ||
}; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fresco only supports limited source types for encoded image:
https://github.com/facebook/fresco/blob/v1.3.0/imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerSequenceFactory.java#L169
For example:
SOURCE_TYPE_LOCAL_CONTENT
(content://) which is returned fromRollCamera
is not supportedUse
ContentResolver.openInputStream
together with BitmapUtil.decodeDimensions(...) for those not supported types.Actually
BitmapUtil.decodeDimensions
probably has better performance than loading the fully encoded image since it only needs to decode the metadata. So I suggest use that when possible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orenklein @foghina
See my approach at bood@ea4b4dd
I'll make another PR if it looks good.