-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for onMomentumScrollEnd #15144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify in the description the difference with onScrollAnimationEnd
?
And please use consistent description style, like "Called when ...".
Absolutely! Also, FWIW, I don't think that onScrollAnimationEnd is ever called... https://snack.expo.io/BJyf5OGIW react-native/React/Views/RCTScrollView.m Line 765 in 603cc48
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@tomasreimers Yeah... You are right. Thank you!
I will add it to my plans. (Or a PR is always welcome. 😄) |
(1) Done: #15156 (Nothing at FB is someone else's problem, right? ;) ) (2) Already done (I think...):
|
Awesome! Now we just have to mention this in the documentation. |
Summary: <!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. In other words, a test plan is *required*. Bonus points for screenshots and videos! Please read the Contribution Guidelines at https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md to learn more about contributing to React Native. Happy contributing! --> Closes #15144 Differential Revision: D5478574 Pulled By: shergin fbshipit-source-id: 33c49f0efdfb3a518e1ee254b1dc01ec22f09269
No description provided.