-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6.0-rc #1535
Closed
Closed
0.6.0-rc #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
* Adding intros for learning guide, react native, react, and updaing the more resources section. * Adding intros for learning guide, react native, react, and updaing the more resources section. * Adding intros for learning guide, react native, react, and updaing the more resources section. * Language linting fixes. * typo and rewording * Updating intro to make it more universal * JS Engines, not browsers * Matching person our->your * Grammar edits and clarifying useState usage * Removing JS.coach because it's not come up in user interviews as a reliable source and we cannot verify why it's in the docs. * Clarifying Hooks and functional syntaxes * Revising useState() example * Updating intro to explain more deeply the first React component people make and switching most instances of 'we' to 'you' as per the STYLEGUIDE. * Unlocking hidden code example * Moving props around a bit to flow better * use defaultValue instead of value so folks can actually 'type in me' * Further clarifying curly braces. * Fixing the diagram location. * adding space around {Text} * Update docs/introduction.md localhost sneaked in XD Co-Authored-By: Brent Vatne <brentvatne@gmail.com> * Refer to 'functional components' as 'function components'. * Adding back props, state, and tutorial. Forwarding should be done after the docs move out of Next. Would breack current docs. * typo fix docs/intro-react-native-components.md Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Update docs/introduction.md Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * bumping up environment to the prereqs section. * languange linter rephrasing * Updating all intro docs to refer to class components * Indentation precheck * Making examples about cats * Making it so that notes and syntax switchers also maintain highlighting. This was harder than it sounded and the code is ugly and I'm not sorry. * carats -> caret * fixing run on * Minor tweaks and typos ask per Christoph and Dan * tweaks and JSX editry * more tweaks ala Dan * final tweaks for the night * removing Babel bit * 'many backgrounds' * adding meta descriptions to pages * Removing extraneous Image example from intro. * Cat doesn't pass name, name is passed TO cat * limiting dev environment talk to one call out * mention mobile browser testing environment * Make that Hello World more engaging * removing learning flow's disruptive link * Combining NAtive Components sections for clarity * swap 'nest' for 'contain' * Updating state examples to rock more socks * Updating the components diagram to some swanky new SVG, meow * Updating the components diagram to some swanky new SVG, meow * adding diagram of views in mobile development to introduction page. * Updating SVG and making local path viewable on netlify—we need a domain. * Updating SVG and making local path viewable on netlify—we need a domain. * Replacing Placekittens with some illustrations * Cleaning up SVG diagram's text styling * Updating references to tutorial and getting started in the docs * Making diagrams visible on netlify—plz revert ok * making them tables shine * Also the previous/next button was off * Android before iOS * final tweaks * A few more tweaks * removing 'just' * Adding master files for the illustrations. * Adding absolute paths for artworks and nixing old CSS * Removing just Co-authored-by: Brent Vatne <brentvatne@gmail.com> Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.